apollo_network_benchmark: added broadcasting mode selection#11541
Open
Conversation
|
This change is |
This was referenced Jan 8, 2026
Closed
Closed
This was referenced Jan 8, 2026
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| /// Which node ID should do the broadcasting - for OneBroadcast mode | ||
| #[arg(long, env, required_if_eq("mode", "one"))] | ||
| pub broadcaster: Option<u64>, |
There was a problem hiding this comment.
New mode and broadcaster fields are never used
Low Severity
The newly added mode and broadcaster fields on UserArgs, along with the Mode enum, are parsed from CLI arguments but never read by any application logic. In stress_test_node.rs, get_tasks unconditionally calls start_message_sender for every node regardless of mode. A user passing --mode one --broadcaster 5 would expect only node 5 to broadcast, but all nodes will broadcast, making the feature silently non-functional.
Additional Locations (1)
sirandreww-starkware
force-pushed
the
12-09-apollo_network_benchmark_added_message_broadcasting_task
branch
from
a00a4b2 to
f1147e4
Compare
sirandreww-starkware
force-pushed
the
01-07-apollo_network_benchmark_added_broadcasting_mode_selection
branch
from
502522a to
1165b86
Compare
sirandreww-starkware
changed the base branch from
12-09-apollo_network_benchmark_added_message_broadcasting_task
to
graphite-base/11541
sirandreww-starkware
force-pushed
the
graphite-base/11541
branch
from
f1147e4 to
8d2cd59
Compare
sirandreww-starkware
force-pushed
the
01-07-apollo_network_benchmark_added_broadcasting_mode_selection
branch
from
1165b86 to
0e35ff2
Compare
sirandreww-starkware
changed the base branch from
graphite-base/11541
to
12-09-apollo_network_benchmark_added_message_broadcasting_task
sirandreww-starkware
force-pushed
the
12-09-apollo_network_benchmark_added_message_broadcasting_task
branch
from
8d2cd59 to
e25a2b7
Compare
sirandreww-starkware
force-pushed
the
01-07-apollo_network_benchmark_added_broadcasting_mode_selection
branch
from
0e35ff2 to
a56150d
Compare
This was referenced Feb 19, 2026
sirandreww-starkware
force-pushed
the
12-09-apollo_network_benchmark_added_message_broadcasting_task
branch
from
e25a2b7 to
fa29577
Compare
sirandreww-starkware
force-pushed
the
01-07-apollo_network_benchmark_added_broadcasting_mode_selection
branch
from
a56150d to
345946a
Compare
sirandreww-starkware
force-pushed
the
12-09-apollo_network_benchmark_added_message_broadcasting_task
branch
from
fa29577 to
bf7d9a3
Compare
sirandreww-starkware
force-pushed
the
01-07-apollo_network_benchmark_added_broadcasting_mode_selection
branch
from
345946a to
049171c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: adds new CLI parsing options (
modeand conditionalbroadcaster) without changing network logic in this PR.Overview
Adds a new
ModeCLI/serde enum to select stress-test broadcast behavior (allvsone).Extends
UserArgswith--mode(defaultall) and a--broadcasternode ID that is required whenmode=one, plus aDisplayimpl forModeto match existing enum formatting.Written by Cursor Bugbot for commit 049171c. This will update automatically on new commits. Configure here.