Skip to content

Conversation

@sirandreww-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @noamsp-starkware)

@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from a65b9ee to a493212 Compare December 9, 2025 12:15
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from a493212 to b728be3 Compare December 11, 2025 12:46
@graphite-app graphite-app bot changed the base branch from 12-07-apollo_network_benchmark_setup_tokio_metrics_exporter to graphite-base/10610 December 11, 2025 18:55
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from b728be3 to 28a923b Compare December 14, 2025 11:30
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/10610 to 12-07-apollo_network_benchmark_setup_tokio_metrics_exporter December 14, 2025 11:30
@sirandreww-starkware sirandreww-starkware changed the base branch from 12-07-apollo_network_benchmark_setup_tokio_metrics_exporter to graphite-base/10610 December 15, 2025 08:51
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from 28a923b to ef6a5fb Compare December 15, 2025 08:51
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/10610 to main December 15, 2025 08:51
Copy link
Contributor

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noamsp-starkware reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)


crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 21 at r2 (raw file):

    /// Gets all the tasks that need to be run
    async fn get_tasks(&mut self) -> Vec<BoxFuture<'static, ()>> {
        Vec::new()

Why is this empty?

Copy link
Contributor

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)


crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 21 at r2 (raw file):

Previously, noamsp-starkware wrote…

Why is this empty?

I see now that in the following PR the logic for this is actually implemented.
I suggest adding a todo for that. unblocking.

Copy link
Contributor

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)

@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from ef6a5fb to b626406 Compare December 22, 2025 09:44
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 5 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Dec 22, 2025
Merged via the queue into main with commit c3c7db1 Dec 22, 2025
37 of 39 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants