-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_network_benchmark: added running tasks infrastructure #10610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_network_benchmark: added running tasks infrastructure #10610
Conversation
d5136b0 to
cf44021
Compare
d27dd40 to
a65b9ee
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @noamsp-starkware)
a65b9ee to
a493212
Compare
a493212 to
b728be3
Compare
6360c64 to
5fe815b
Compare
b728be3 to
28a923b
Compare
28a923b to
ef6a5fb
Compare
5fe815b to
0abe6bf
Compare
noamsp-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noamsp-starkware reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)
crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 21 at r2 (raw file):
/// Gets all the tasks that need to be run async fn get_tasks(&mut self) -> Vec<BoxFuture<'static, ()>> { Vec::new()
Why is this empty?
noamsp-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)
crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 21 at r2 (raw file):
Previously, noamsp-starkware wrote…
Why is this empty?
I see now that in the following PR the logic for this is actually implemented.
I suggest adding a todo for that. unblocking.
noamsp-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)
ef6a5fb to
b626406
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sirandreww-starkware reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).

No description provided.