apollo_network_benchmark: added message receiving task

[sirandreww-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

• apollo_network_benchmark: added message broadcasting task #10734 : 2 dependent PRs (#8303 , #11541 )
• apollo_network_benchmark: added network usage metrics #10661
• apollo_network_benchmark: added cpu and memory metrics #10660
• apollo_network_benchmark: added receive metrics #10626
• apollo_network_benchmark: added message receiving task #10625 👈 (View in Graphite)
• apollo_network_benchmark: added infrastructure for multiple network protocols #10624
• apollo_network_benchmark: added network manager creation logic #10611
• apollo_network_benchmark: added running tasks infrastructure #10610
• apollo_network_benchmark: setup tokio metrics exporter #10609
• apollo_network_benchmark: setup Prometheus metrics exporter #10608
• apollo_network_benchmark: setup trace logging in benchmark #10607
• apollo_network_benchmark: moved args file #10606
• apollo_network_benchmark: added the message that will be used by the benchmark #10557
• apollo_network_benchmark: added arguemt parsing using clap #10556
• apollo_network_benchmark: new crate for benchmarking the p2p network stack #10551
• apollo_network: removed old network stress test code #10550
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[noamsp-starkware]

@noamsp-starkware reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @sirandreww-starkware)

---

crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/handlers.rs line 16 at r1 (raw file):

        Ok(duration) => duration.as_secs_f64(),
        Err(_) => {
            let negative_duration = start_time.duration_since(end_time).unwrap();

You can extract the duration from the error returned.

---

crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/handlers.rs line 16 at r1 (raw file):

        Ok(duration) => duration.as_secs_f64(),
        Err(_) => {
            let negative_duration = start_time.duration_since(end_time).unwrap();

Don't we want to panic here? It seems to me like we could end up with false metrics if we just sweep the problem under the carpet like this.

[sirandreww-starkware]

@sirandreww-starkware made 2 comments.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware and @sirandreww-starkware).

---

crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/handlers.rs line 16 at r1 (raw file):

Previously, noamsp-starkware wrote…

You can extract the duration from the error returned.

I went with panicking when this happens instead.

---

crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/handlers.rs line 16 at r1 (raw file):

Previously, noamsp-starkware wrote…

Don't we want to panic here? It seems to me like we could end up with false metrics if we just sweep the problem under the carpet like this.

Done.

[noamsp-starkware]

@noamsp-starkware reviewed 3 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).

[graphite-app]

Merge activity

• Dec 28, 2:25 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.