Skip to content

Conversation

@sirandreww-starkware
Copy link
Contributor

apollo_network_benchmark: added infrastructure for multiple network protocols

apollo_network_benchmark: added message receiving task

@reviewable-StarkWare
Copy link

This change is Reviewable

@sirandreww-starkware sirandreww-starkware force-pushed the 12-08-apollo_network_benchmark_added_infrastructure_for_multiple_network_protocols branch from 883aea6 to ee54a68 Compare December 8, 2025 11:17
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 of 6 files at r1.
Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @noamsp-starkware)

@sirandreww-starkware sirandreww-starkware force-pushed the 12-08-apollo_network_benchmark_added_infrastructure_for_multiple_network_protocols branch from ee54a68 to 59af4d3 Compare December 9, 2025 12:15
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from 54c2611 to 00ef0d8 Compare December 9, 2025 12:15
@sirandreww-starkware sirandreww-starkware force-pushed the 12-08-apollo_network_benchmark_added_infrastructure_for_multiple_network_protocols branch from 59af4d3 to 9731b32 Compare December 11, 2025 12:46
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from 00ef0d8 to cc8cc41 Compare December 11, 2025 12:46
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from cc8cc41 to db4b29a Compare December 14, 2025 11:30
@sirandreww-starkware sirandreww-starkware force-pushed the 12-08-apollo_network_benchmark_added_infrastructure_for_multiple_network_protocols branch from 9731b32 to 21854c2 Compare December 14, 2025 11:30
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from db4b29a to e695ede Compare December 15, 2025 08:51
@sirandreww-starkware sirandreww-starkware force-pushed the 12-08-apollo_network_benchmark_added_infrastructure_for_multiple_network_protocols branch from 21854c2 to 9a27d08 Compare December 15, 2025 08:51
Copy link
Contributor

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noamsp-starkware reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)


crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/protocol.rs line 85 at r2 (raw file):

                receiver
                    .for_each(|message| async move {
                        let peer_id = message.1.originator_id.private_get_peer_id();

I'd prefer destructuring for readability and to force handling the option.
something like:
let (payload_opt, meta) = message;
let peer_id = meta.originator_id.private_get_peer_id();
let payload = payload_opt.expect("...");

@sirandreww-starkware sirandreww-starkware force-pushed the 12-08-apollo_network_benchmark_added_infrastructure_for_multiple_network_protocols branch from 9a27d08 to 79356bf Compare December 22, 2025 09:44
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch 2 times, most recently from 39165f3 to c04629b Compare December 22, 2025 11:11
@sirandreww-starkware sirandreww-starkware force-pushed the 12-08-apollo_network_benchmark_added_infrastructure_for_multiple_network_protocols branch from 79356bf to 92ff2e3 Compare December 22, 2025 11:11
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 1 comment.
Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware).


crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/protocol.rs line 85 at r2 (raw file):

Previously, noamsp-starkware wrote…

I'd prefer destructuring for readability and to force handling the option.
something like:
let (payload_opt, meta) = message;
let peer_id = meta.originator_id.private_get_peer_id();
let payload = payload_opt.expect("...");

Done.

@graphite-app graphite-app bot changed the base branch from 12-07-apollo_network_benchmark_added_network_manager_creation_logic to graphite-base/10624 December 22, 2025 11:14
@sirandreww-starkware sirandreww-starkware force-pushed the 12-08-apollo_network_benchmark_added_infrastructure_for_multiple_network_protocols branch from 92ff2e3 to 2bad837 Compare December 23, 2025 11:03
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/10624 to 12-07-apollo_network_benchmark_added_network_manager_creation_logic December 23, 2025 11:03
Copy link
Contributor

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noamsp-starkware resolved 1 discussion.
Reviewable status: 3 of 6 files reviewed, all discussions resolved (waiting on @ShahakShama).

Copy link
Contributor

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@noamsp-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama).

@sirandreww-starkware sirandreww-starkware changed the base branch from 12-07-apollo_network_benchmark_added_network_manager_creation_logic to main December 28, 2025 13:38
@sirandreww-starkware sirandreww-starkware force-pushed the 12-08-apollo_network_benchmark_added_infrastructure_for_multiple_network_protocols branch from 2bad837 to 3a652f4 Compare December 28, 2025 13:39
@graphite-app
Copy link

graphite-app bot commented Dec 28, 2025

Merge activity

  • Dec 28, 1:39 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 6 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Dec 28, 2025
Merged via the queue into main with commit 7052ec5 Dec 28, 2025
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants