-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_network_benchmark: added infrastructure for multiple network protocols #10624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_network_benchmark: added infrastructure for multiple network protocols #10624
Conversation
883aea6 to
ee54a68
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 1 of 6 files at r1.
Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @noamsp-starkware)
ee54a68 to
59af4d3
Compare
54c2611 to
00ef0d8
Compare
59af4d3 to
9731b32
Compare
00ef0d8 to
cc8cc41
Compare
cc8cc41 to
db4b29a
Compare
9731b32 to
21854c2
Compare
db4b29a to
e695ede
Compare
21854c2 to
9a27d08
Compare
noamsp-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noamsp-starkware reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)
crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/protocol.rs line 85 at r2 (raw file):
receiver .for_each(|message| async move { let peer_id = message.1.originator_id.private_get_peer_id();
I'd prefer destructuring for readability and to force handling the option.
something like:
let (payload_opt, meta) = message;
let peer_id = meta.originator_id.private_get_peer_id();
let payload = payload_opt.expect("...");
9a27d08 to
79356bf
Compare
39165f3 to
c04629b
Compare
79356bf to
92ff2e3
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sirandreww-starkware made 1 comment.
Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware).
crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/protocol.rs line 85 at r2 (raw file):
Previously, noamsp-starkware wrote…
I'd prefer destructuring for readability and to force handling the option.
something like:
let (payload_opt, meta) = message;
let peer_id = meta.originator_id.private_get_peer_id();
let payload = payload_opt.expect("...");
Done.
c04629b to
c636441
Compare
92ff2e3 to
2bad837
Compare
noamsp-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noamsp-starkware resolved 1 discussion.
Reviewable status: 3 of 6 files reviewed, all discussions resolved (waiting on @ShahakShama).
noamsp-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noamsp-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ShahakShama).
2bad837 to
3a652f4
Compare
Merge activity
|
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sirandreww-starkware reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ShahakShama).

apollo_network_benchmark: added infrastructure for multiple network protocols
apollo_network_benchmark: added message receiving task