Skip to content

apollo_network_benchmark: setup trace logging in benchmark #10607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sirandreww-starkware merged 1 commit into from
Dec 11, 2025
Merged

apollo_network_benchmark: setup trace logging in benchmark #10607

sirandreww-starkware merged 1 commit into from
Dec 11, 2025

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Dec 7, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025 •
edited
Loading

Artifacts upload workflows:

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Dec 7, 2025

This change is Reviewable

This was referenced Dec 7, 2025
Merged
Merged
Merged
Merged
@sirandreww-starkware Graphite App
Copy link
Contributor Author

sirandreww-starkware commented Dec 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 7, 2025
Merged
Merged
Merged
Merged
Merged
@sirandreww-starkware sirandreww-starkware self-assigned this Dec 7, 2025
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review December 7, 2025 19:16
@sirandreww-starkware sirandreww-starkware force-pushed the 12-04-apollo_network_benchmark_moved_args_file branch from c8c4982 to b606553 Compare December 8, 2025 11:12
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_setup_trace_logging_in_benchmark branch from a95a845 to 790ee1a Compare December 8, 2025 11:12
This was referenced Dec 8, 2025
Merged
Merged
Merged
ShahakShama
ShahakShama approved these changes Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 of 4 files at r1.
Reviewable status: 1 of 4 files reviewed, all discussions resolved (waiting on @noamsp-starkware)

@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_setup_trace_logging_in_benchmark branch from 790ee1a to 74b36f1 Compare December 9, 2025 12:15
@sirandreww-starkware sirandreww-starkware force-pushed the 12-04-apollo_network_benchmark_moved_args_file branch from b606553 to bd06e34 Compare December 9, 2025 12:15
This was referenced Dec 9, 2025
Open
Open
noamsp-starkware
noamsp-starkware approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@noamsp-starkware reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware)

@graphite-app graphite-app bot changed the base branch from 12-04-apollo_network_benchmark_moved_args_file to graphite-base/10607 December 9, 2025 22:14
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_setup_trace_logging_in_benchmark branch from 74b36f1 to fa19a6f Compare December 10, 2025 07:27
@graphite-app graphite-app bot changed the base branch from graphite-base/10607 to main December 10, 2025 07:28
@graphite-app
Copy link

graphite-app bot commented Dec 10, 2025

Merge activity

  • Dec 10, 7:28 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

sirandreww-starkware
sirandreww-starkware commented Dec 11, 2025
View reviewed changes
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware)

sirandreww-starkware
sirandreww-starkware commented Dec 11, 2025
View reviewed changes
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 3 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware)

@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_setup_trace_logging_in_benchmark branch from fa19a6f to 9f9011e Compare December 11, 2025 12:46
@sirandreww-starkware sirandreww-starkware mentioned this pull request Dec 11, 2025
Open
@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 5d055b5 Dec 11, 2025
36 of 46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noamsp-starkware noamsp-starkware Awaiting requested review from noamsp-starkware

@ShahakShama ShahakShama Awaiting requested review from ShahakShama

Assignees

@sirandreww-starkware sirandreww-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sirandreww-starkware @reviewable-StarkWare @ShahakShama @noamsp-starkware