Skip to content

Conversation

@sirandreww-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 of 4 files at r1.
Reviewable status: 1 of 4 files reviewed, all discussions resolved (waiting on @noamsp-starkware)

@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from a65b9ee to a493212 Compare December 9, 2025 12:15
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from 54c2611 to 00ef0d8 Compare December 9, 2025 12:15
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from a493212 to b728be3 Compare December 11, 2025 12:46
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from 00ef0d8 to cc8cc41 Compare December 11, 2025 12:46
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from cc8cc41 to db4b29a Compare December 14, 2025 11:30
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from b728be3 to 28a923b Compare December 14, 2025 11:30
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from 28a923b to ef6a5fb Compare December 15, 2025 08:51
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from db4b29a to e695ede Compare December 15, 2025 08:51
Copy link
Contributor

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@noamsp-starkware reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sirandreww-starkware)


crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 25 at r2 (raw file):

        let peer_private_key_hex =
            peer_private_key.iter().map(|byte| format!("{byte:02x}")).collect::<String>();
        info!("Secret Key: {peer_private_key_hex:#?}");

Consider moving this log into create_peer_private_key so the create_network_config is cleaner.


crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 33 at r2 (raw file):

        };

        network_config.discovery_config.heartbeat_interval = Duration::from_secs(99999999);

consider using u64::MAX

@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_running_tasks_infrastructure branch from ef6a5fb to b626406 Compare December 22, 2025 09:44
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from e695ede to 39165f3 Compare December 22, 2025 09:44
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware made 2 comments and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).


crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 25 at r2 (raw file):

Previously, noamsp-starkware wrote…

Consider moving this log into create_peer_private_key so the create_network_config is cleaner.

Done.


crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 33 at r2 (raw file):

Previously, noamsp-starkware wrote…

consider using u64::MAX

Done.

Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware changed the base branch from 12-07-apollo_network_benchmark_added_running_tasks_infrastructure to graphite-base/10611 December 22, 2025 11:11
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/10611 to main December 22, 2025 11:11
@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from 39165f3 to c04629b Compare December 22, 2025 11:11
@graphite-app
Copy link

graphite-app bot commented Dec 22, 2025

Merge activity

  • Dec 22, 11:15 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 12-07-apollo_network_benchmark_added_network_manager_creation_logic branch from c04629b to c636441 Compare December 23, 2025 11:03
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Dec 28, 2025
Merged via the queue into main with commit 2194fef Dec 28, 2025
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants