-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_network_benchmark: added network manager creation logic #10611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_network_benchmark: added network manager creation logic #10611
Conversation
d27dd40 to
a65b9ee
Compare
c52f2ca to
54c2611
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 1 of 4 files at r1.
Reviewable status: 1 of 4 files reviewed, all discussions resolved (waiting on @noamsp-starkware)
a65b9ee to
a493212
Compare
54c2611 to
00ef0d8
Compare
a493212 to
b728be3
Compare
00ef0d8 to
cc8cc41
Compare
cc8cc41 to
db4b29a
Compare
b728be3 to
28a923b
Compare
28a923b to
ef6a5fb
Compare
db4b29a to
e695ede
Compare
noamsp-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noamsp-starkware reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sirandreww-starkware)
crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 25 at r2 (raw file):
let peer_private_key_hex = peer_private_key.iter().map(|byte| format!("{byte:02x}")).collect::<String>(); info!("Secret Key: {peer_private_key_hex:#?}");
Consider moving this log into create_peer_private_key so the create_network_config is cleaner.
crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 33 at r2 (raw file):
}; network_config.discovery_config.heartbeat_interval = Duration::from_secs(99999999);
consider using u64::MAX
ef6a5fb to
b626406
Compare
e695ede to
39165f3
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sirandreww-starkware made 2 comments and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).
crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 25 at r2 (raw file):
Previously, noamsp-starkware wrote…
Consider moving this log into create_peer_private_key so the create_network_config is cleaner.
Done.
crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs line 33 at r2 (raw file):
Previously, noamsp-starkware wrote…
consider using u64::MAX
Done.
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sirandreww-starkware reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).
39165f3 to
c04629b
Compare
Merge activity
|
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sirandreww-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).
c04629b to
c636441
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sirandreww-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware).

No description provided.