Skip to content

apollo_network_benchmark: added broadcast metrics tracking#11543

Open
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_modefrom
01-07-apollo_network_benchmark_added_broadcast_metrics_tracking
Open

apollo_network_benchmark: added broadcast metrics tracking#11543
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_modefrom
01-07-apollo_network_benchmark_added_broadcast_metrics_tracking

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026

Note

Low Risk
Adds metrics instrumentation to the broadcast stress-test sender path; risk is low since it doesn’t change protocol behavior beyond minor timing/CPU overhead for metric collection.

Overview
Adds broadcast send-side instrumentation to the broadcast network stress test node.

Defines and registers new metrics for theoretical heartbeat/throughput plus per-send bytes, counts, byte-sum, and send latency histogram, and records them from send_stress_test_messages (including a new get_throughput helper).

Written by Cursor Bugbot for commit 8c425d7. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 8, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review January 8, 2026 17:42
@sirandreww-starkware sirandreww-starkware self-assigned this Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_broadcast_metrics_tracking branch from 2aae34d to ca949d1 Compare February 16, 2026 09:10
@sirandreww-starkware sirandreww-starkware changed the base branch from 01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_mode to graphite-base/11543 February 18, 2026 13:18
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_broadcast_metrics_tracking branch from ca949d1 to 3b2e887 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/11543 to 01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_mode February 19, 2026 07:25
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_mode branch from 030490b to e340ed6 Compare March 16, 2026 15:13
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_broadcast_metrics_tracking branch from 64fc04b to 8c425d7 Compare March 16, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants