apollo_network_benchmark: add ReveresedSqmr receiver and registration#11555
Conversation
This was referenced Jan 8, 2026
Contributor
Author
This was referenced Jan 8, 2026
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
| ); | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Tight busy-loop on repeated connection failure
Medium Severity
The ReveresedSqmr receiver's outer loop has no delay or backoff in the Err(e) arm. Since send_new_query fails immediately (the underlying mpsc::SendError is non-blocking), a persistent failure will cause a tight CPU-spinning loop that also floods logs with error messages. A small sleep or backoff in the error branch would prevent this.
Additional Locations (1)
471fd3f to
a929882
Compare
0192b6d to
a024e8b
Compare
a929882 to
a354cd2
Compare
a024e8b to
31afa17
Compare
This was referenced Feb 19, 2026
a354cd2 to
a153019
Compare
31afa17 to
5436db8
Compare
a153019 to
4541183
Compare
5436db8 to
3bd9208
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Note
Low Risk
Limited to benchmark/stress-test code, but introduces long-running loops and new SQMR query/response handling that could affect test stability or resource usage if misbehaving.
Overview
Adds full support for
NetworkProtocol::ReveresedSqmrin the stress-test node by registering SQMR client/server channels instead oftodo!()and exposing them via newMessageSender::ReveresedSqmr/MessageReceiver::ReveresedSqmrvariants.Implements a reversed SQMR flow: the sender tracks the latest incoming server-side query and pushes broadcast payloads as responses, while the receiver continuously opens empty queries and forwards streamed responses into the existing
for_eachcallback (with basic error logging/retry behavior).Written by Cursor Bugbot for commit 3bd9208. This will update automatically on new commits. Configure here.