Skip to content

apollo_network_benchmark: add ReveresedSqmr receiver and registration#11555

Open
sirandreww-starkware wants to merge 1 commit into01-08-apollo_network_benchmark_add_reveresedsqmrsender_struct_and_implementationfrom
01-08-apollo_network_benchmark_add_reveresedsqmr_receiver_and_registration
Open

apollo_network_benchmark: add ReveresedSqmr receiver and registration#11555
sirandreww-starkware wants to merge 1 commit into01-08-apollo_network_benchmark_add_reveresedsqmrsender_struct_and_implementationfrom
01-08-apollo_network_benchmark_add_reveresedsqmr_receiver_and_registration

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026

Note

Low Risk
Limited to benchmark/stress-test code, but introduces long-running loops and new SQMR query/response handling that could affect test stability or resource usage if misbehaving.

Overview
Adds full support for NetworkProtocol::ReveresedSqmr in the stress-test node by registering SQMR client/server channels instead of todo!() and exposing them via new MessageSender::ReveresedSqmr/MessageReceiver::ReveresedSqmr variants.

Implements a reversed SQMR flow: the sender tracks the latest incoming server-side query and pushes broadcast payloads as responses, while the receiver continuously opens empty queries and forwards streamed responses into the existing for_each callback (with basic error logging/retry behavior).

Written by Cursor Bugbot for commit 3bd9208. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

);
}
}
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tight busy-loop on repeated connection failure

Medium Severity

The ReveresedSqmr receiver's outer loop has no delay or backoff in the Err(e) arm. Since send_new_query fails immediately (the underlying mpsc::SendError is non-blocking), a persistent failure will cause a tight CPU-spinning loop that also floods logs with error messages. A small sleep or backoff in the error branch would prevent this.

Additional Locations (1)

Fix in Cursor Fix in Web

@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_reveresedsqmrsender_struct_and_implementation branch from 471fd3f to a929882 Compare February 16, 2026 09:10
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_reveresedsqmr_receiver_and_registration branch from 0192b6d to a024e8b Compare February 16, 2026 09:10
@github-actions github-actions bot removed the stale label Feb 17, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_reveresedsqmrsender_struct_and_implementation branch from a929882 to a354cd2 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_reveresedsqmr_receiver_and_registration branch from a024e8b to 31afa17 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_reveresedsqmrsender_struct_and_implementation branch from a354cd2 to a153019 Compare February 19, 2026 08:04
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_reveresedsqmr_receiver_and_registration branch from 31afa17 to 5436db8 Compare February 19, 2026 08:04
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_reveresedsqmrsender_struct_and_implementation branch from a153019 to 4541183 Compare March 16, 2026 15:13
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_reveresedsqmr_receiver_and_registration branch from 5436db8 to 3bd9208 Compare March 16, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants