Conversation
8c2a594 to
73eaa21
Compare
504b9b9 to
86c458f
Compare
73eaa21 to
986b446
Compare
86c458f to
044ec48
Compare
986b446 to
494b83c
Compare
10b3104 to
896b20e
Compare
494b83c to
7b1c4df
Compare
896b20e to
be214f3
Compare
noa-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @arad-starkware)
workspace/apps/staking/contracts/src/flow_test/test.cairo line 2418 at r2 (raw file):
/// Test get_stakers. /// Switch rest of delegation to staker 2. /// Test get_stakers.
Suggestion:
/// Flow:
/// 2 Stakers stake.
/// Delegate to staker 1.
/// Test get_stakers.
/// Delegator full intent.
/// Test get_stakers.
/// Delegator switch half of delegation to staker 2.
/// Test get_stakers.
/// Delegator switch rest of delegation to staker 2.
/// Test get_stakers.workspace/apps/staking/contracts/src/flow_test/test.cairo line 2484 at r2 (raw file):
( staker_1.staker.address, mul_wide_and_div(lhs: STRK_WEIGHT_FACTOR, rhs: stake_amount, div: stake_amount * 5 / 2)
Suggestion:
stake_amount * 2 + stake_amount / 2workspace/apps/staking/contracts/src/flow_test/test.cairo line 2491 at r2 (raw file):
staker_2.staker.address, mul_wide_and_div( lhs: STRK_WEIGHT_FACTOR, rhs: stake_amount * 3 / 2, div: stake_amount * 5 / 2,
Suggestion:
stake_amount * 2 + stake_amount / 2be214f3 to
1bb31ed
Compare
arad-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @arad-starkware and @noa-starkware)
workspace/apps/staking/contracts/src/flow_test/test.cairo line 2418 at r2 (raw file):
/// Test get_stakers. /// Switch rest of delegation to staker 2. /// Test get_stakers.
Done
workspace/apps/staking/contracts/src/flow_test/test.cairo line 2484 at r2 (raw file):
( staker_1.staker.address, mul_wide_and_div(lhs: STRK_WEIGHT_FACTOR, rhs: stake_amount, div: stake_amount * 5 / 2)
I'd rather leave it as is
workspace/apps/staking/contracts/src/flow_test/test.cairo line 2491 at r2 (raw file):
staker_2.staker.address, mul_wide_and_div( lhs: STRK_WEIGHT_FACTOR, rhs: stake_amount * 3 / 2, div: stake_amount * 5 / 2,
same
7b1c4df to
1ee509f
Compare
c37d705 to
b4bf2cf
Compare
1ee509f to
c409301
Compare
noa-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @arad-starkware)
c409301 to
c265e2e
Compare
4cd417a to
2337137
Compare
1908dd3 to
c428848
Compare
2337137 to
8d9378d
Compare
c428848 to
93ede53
Compare
c42088b to
9da15c6
Compare
93ede53 to
cc0c679
Compare
9da15c6 to
88f4f8b
Compare
cc0c679 to
920d336
Compare
88f4f8b to
928b0df
Compare
9a7c1ae to
280e737
Compare
928b0df to
2e3484c
Compare
323336e to
72468ce
Compare
2e3484c to
8eac940
Compare
8eac940 to
6f24aa1
Compare
72468ce to
9f9cf2c
Compare
6f24aa1 to
003bd3c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 95.43% 95.53% +0.09%
==========================================
Files 45 45
Lines 9446 9657 +211
==========================================
+ Hits 9015 9226 +211
Misses 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merge activity
|

This change is
Note
Adds a test covering
get_stakersbehavior when a delegator switches delegation between stakers across epochs, and cleans up flow ideas.get_stakers_switch_delegation_flow_testinflow_test/test.cairoto verifyget_stakersweights across epochs during full exit intent and stepwise delegation switches between two stakers.flow_test/flow_ideas.mdby removing the obsoleteget_stakersidea section.Written by Cursor Bugbot for commit 003bd3c. This will update automatically on new commits. Configure here.