test: add get stakers delegation undelegation flow

[arad-starkware]

This change is 

---

Note

Add a new end-to-end test validating get_stakers across delegation and undelegation intents/actions over epochs, and prune one obsolete idea from flow_ideas.

• Tests:
  • Add get_stakers_delegation_undelegation_flow_test in workspace/apps/staking/contracts/src/flow_test/test.cairo:
    • Stakes two stakers, delegates STRK, then performs partial and full undelegation (intent/action).
    • Asserts get_stakers weights at current and subsequent K-epochs, verifying staking-power redistribution via mul_wide_and_div and STRK_WEIGHT_FACTOR.
• Docs:
  • Remove - Undelegate, get stakers. from flow_test/flow_ideas.md.

^{Written by Cursor Bugbot for commit c460717. This will update automatically on new commits. Configure here.}

[arad-starkware]

• test: add get_stakers 100% power test #34
• test: add get_stakers switch flow #33
• test: add get_stakers increase stake flow #32
• test: add get_stakers enable disable tokens flow #31
• test: add get stakers delegation undelegation flow #30 👈 (View in Graphite)
• add get_stakers btc and strk delegations flow #29
• test: add get_stakers exit action flow #28
• test: add get_stakers exit intent flow #27
• test: add get_stakers with zero balance flow #26
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[noa-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @arad-starkware)

---

workspace/apps/staking/contracts/src/flow_test/test.cairo line 2138 at r2 (raw file):

        (staker_1.staker.address, STRK_WEIGHT_FACTOR / 2, Option::None),
        (staker_2.staker.address, STRK_WEIGHT_FACTOR / 2, Option::None),
    ]

same as above

Code quote:

    let expected_stakers = array![
        (staker_1.staker.address, STRK_WEIGHT_FACTOR / 2, Option::None),
        (staker_2.staker.address, STRK_WEIGHT_FACTOR / 2, Option::None),
    ]

[arad-starkware]

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @arad-starkware)

---

workspace/apps/staking/contracts/src/flow_test/test.cairo line 2138 at r2 (raw file):

Previously, noa-starkware wrote…

same as above

Done

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.46%. Comparing base (a28d60e) to head (c460717).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   95.43%   95.46%   +0.03%     
==========================================
  Files          45       45              
  Lines        9446     9510      +64     
==========================================
+ Hits         9015     9079      +64     
  Misses        431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[noa-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @arad-starkware)

---

workspace/apps/staking/contracts/src/flow_test/test.cairo line 2157 at r3 (raw file):

    assert!(stakers == expected_stakers);

    // Undelegate

Maybe test partial intent?

[cursor]

Bug: Missing exit wait window before delegator exit action

The test calls delegator_exit_action without advancing time by the exit wait window after delegator_exit_intent. The exit_delegation_pool_action function requires that sufficient time has passed (the exit wait window) since the intent, but the test only calls advance_k_epochs which advances K epochs. The exit wait window is typically longer than K epochs, so this call will fail with INTENT_WINDOW_NOT_FINISHED error. Other tests in the codebase consistently call advance_time(time: system.staking.get_exit_wait_window()) between intent and action calls.

workspace/apps/staking/contracts/src/flow_test/test.cairo#L2201-L2202

starknet-staking/workspace/apps/staking/contracts/src/flow_test/test.cairo

Lines 2201 to 2202 in 1542855

	// Undelegate action
	system.advance_exit_wait_window();

 

---

[arad-starkware]

Reviewable status: 0 of 2 files reviewed, all discussions resolved

---

workspace/apps/staking/contracts/src/flow_test/test.cairo line 2157 at r3 (raw file):

Previously, noa-starkware wrote…

Maybe test partial intent?

Done

[noa-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @arad-starkware)

---

workspace/apps/staking/contracts/src/flow_test/test.cairo line 2116 at r5 (raw file):

    let mut system = SystemConfigTrait::basic_stake_flow_cfg(:cfg).deploy();
    let stake_amount = system.staking.get_min_stake();
    let strk_delegation_amount = STRK_CONFIG.min_for_rewards * 3;

why?

Code quote:

* 3

[noa-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @arad-starkware)

[arad-starkware]

Merge activity

• Nov 20, 11:01 AM UTC: @arad-starkware merged this pull request with Graphite.