[hironx client] Remove experimental dependency#470
Open
130s wants to merge 2 commits intostart-jsk:indigo-develfrom
Open
[hironx client] Remove experimental dependency#470130s wants to merge 2 commits intostart-jsk:indigo-develfrom
130s wants to merge 2 commits intostart-jsk:indigo-develfrom
Conversation
875a02c to
f4fbb99
Compare
Contributor
Author
|
Only the backward check for 315.1.10 is failing: |
f4fbb99 to
adc378e
Compare
Contributor
Author
This can happen when either compared arg is None and in this case I think not all temporary methods that I'm removing in this PR are available upstream in hrpsys-base. Will open a PR against. |
Contributor
Author
Done fkanehiro/hrpsys-base#1063. Once that PR gets merged then this hopefully PR will pass the test. |
130s
added a commit
to 130s/rtmros_hironx
that referenced
this pull request
Mar 11, 2017
…passed. **Background** (Same commit message as fkanehiro/hrpsys-base#1113) `setTargetPose` takes a kinematic group as its 1st arg. When invalid value passed, it still tries to solve IK and always fails with an IK solution failure message, which is ambiguous because it failed not because the computation but because the target group name is simply invalid. **Approach to fix** With this change it first checks if the passed value is a registered kinematic group name and if not it fails with the reason accordingly. **Additional note at rtmros_hironx** Same change as fkanehiro/hrpsys-base#1113. This method should be removed as part of start-jsk#470, once fkanehiro/hrpsys-base#1063 resolves.
130s
added a commit
to 130s/rtmros_hironx
that referenced
this pull request
Mar 11, 2017
…passed. **Background** (Same commit message as fkanehiro/hrpsys-base#1113) `setTargetPose` takes a kinematic group as its 1st arg. When invalid value passed, it still tries to solve IK and always fails with an IK solution failure message, which is ambiguous because it failed not because the computation but because the target group name is simply invalid. **Approach to fix** With this change it first checks if the passed value is a registered kinematic group name and if not it fails with the reason accordingly. **Additional note at rtmros_hironx** Same change as fkanehiro/hrpsys-base#1113. This method should be removed as part of start-jsk#470, once fkanehiro/hrpsys-base#1063 resolves.
130s
added a commit
to 130s/rtmros_hironx
that referenced
this pull request
Mar 11, 2017
…passed. **Background** (Same commit message as fkanehiro/hrpsys-base#1113) `setTargetPose` takes a kinematic group as its 1st arg. When invalid value passed, it still tries to solve IK and always fails with an IK solution failure message, which is ambiguous because it failed not because the computation but because the target group name is simply invalid. **Approach to fix** With this change it first checks if the passed value is a registered kinematic group name and if not it fails with the reason accordingly. **Additional note at rtmros_hironx** Same change as fkanehiro/hrpsys-base#1113. This method should be removed as part of start-jsk#470, once fkanehiro/hrpsys-base#1063 resolves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #469 (comment)
Confirmed simple tasks work on RViz simulation via ipython.