[5.x] Improve performance of the data reference updaters#11442
Merged
jasonvarga merged 2 commits into5.xfrom Feb 17, 2025
Merged
[5.x] Improve performance of the data reference updaters#11442jasonvarga merged 2 commits into5.xfrom
jasonvarga merged 2 commits into5.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes some performance improvements to the
GetsItemsContainingDatatrait, responsible for gathering all content items (all entries, terms, globals and users).It's currently used within the asset & term reference updaters, however, it'll soon be used in the UTC dates update script (#11409).
Essentially, instead of loading all items into memory at once (which will cause issues with larger sites), we'll use Laravel's Lazy Collections feature to ensure items can be looped through in a more efficient manner.