[5.x] Update nocache map on response#11650
Merged
jasonvarga merged 2 commits intostatamic:5.xfrom Apr 23, 2025
Merged
Conversation
This improves compatibility with frameworks like Vue where Html gets replaced once it has booted
indykoning
changed the title
jasonvarga
approved these changes
Apr 22, 2025
Member
jasonvarga
left a comment
jasonvarga
left a comment
There was a problem hiding this comment.
I extracted a method to avoid duplicated code, but otherwise great. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves compatibility with frameworks like Vue where Html gets replaced once it has booted.
Why do we need this?
When placing the nocache tag within Vue's scope (usually id="app") our nocache tags aren't actually being replaced anymore.
Why does this happen?
Vue Replaces the html with it's computed html from the virtualdom when booting.
This means the references to the elements we've saved are stale.
Now we update our mapping after the fetch has completed so we can correctly replace our data