Skip to content

[5.x] Update nocache map on response #11650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 2 commits into from
Apr 23, 2025
Merged

[5.x] Update nocache map on response #11650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e474bf
Update nocache map on response
indykoning Apr 2, 2025
7528442
extract method
jasonvarga Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/StaticCaching/Cachers/FileCacher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,13 +207,18 @@ public function getNocacheJs(): string

$default = <<<EOT
(function() {
var els = document.getElementsByClassName('nocache');
var map = {};
for (var i = 0; i < els.length; i++) {
var section = els[i].getAttribute('data-nocache');
map[section] = els[i];
function createMap() {
var map = {};
var els = document.getElementsByClassName('nocache');
for (var i = 0; i < els.length; i++) {
var section = els[i].getAttribute('data-nocache');
map[section] = els[i];
}
return map;
}

var map = createMap();

fetch('/!/nocache', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
Expand All @@ -224,6 +229,8 @@ public function getNocacheJs(): string
})
.then((response) => response.json())
.then((data) => {
map = createMap(); // Recreate map in case the DOM changed.

const regions = data.regions;
for (var key in regions) {
if (map[key]) map[key].outerHTML = regions[key];
Expand Down