feat(@desktop/privacy): Added privacy wall screens for when third party #18750

Khushboo-dev-cpp · 2025-08-29T13:10:08Z

What does the PR do

Implements the Privacy walls for Wallet and Market tabs when Thirdparty services are disabled as defined in designs here https://www.figma.com/design/idUoxN7OIW2Jpp3PMJ1Rl8/Settings----Desktop-Legacy?node-id=26301-22159&m=dev

Affected areas

Architecture compliance

I am familiar with the application architecture and agreed good practices.
My PR is consistent with this document: QML Architecture Guidelines

Screencapture of the functionality

Screen.Recording.2025-08-29.at.15.07.58.mov

Screen.Recording.2025-08-29.at.15.44.43.mov

Impact on end user

How to test

Risk

services are disabled fixes #18512, #18513

status-im-auto · 2025-08-29T13:17:32Z

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`b268ecb`	#1	2025-08-29 13:17:32	~7 min	`tests/nim`	📄`log`
✔️	`b268ecb`	#1	2025-08-29 13:23:35	~13 min	`tests/ui`	📄`log`
✔️	`b268ecb`	#1	2025-08-29 13:27:04	~16 min	`linux/x86_64`	📦`tgz`
✔️	`b268ecb`	#1	2025-08-29 13:27:56	~17 min	`macos/aarch64-nwaku`	🍎`dmg`
✔️	`b268ecb`	#1	2025-08-29 13:28:06	~17 min	`macos/aarch64`	🍎`dmg`
✔️	`b268ecb`	pr18750	2025-08-29 13:38:12	~11 min	`tests/e2e`	📊`rpt`
✔️	`b268ecb`	#1	2025-08-29 13:38:23	~27 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`b268ecb`	#1	2025-08-29 13:39:07	~28 min	`windows/x86_64`	💿`exe`

✔️	`43ea202`	#2	2025-08-29 13:51:29	~7 min	`tests/nim`	📄`log`
✔️	`43ea202`	#2	2025-08-29 13:56:25	~12 min	`tests/ui`	📄`log`
✔️	`43ea202`	#2	2025-08-29 14:06:06	~22 min	`linux/x86_64-nwaku`	📦`tgz`
✔️	`43ea202`	#2	2025-08-29 14:08:08	~23 min	`windows/x86_64`	💿`exe`

…Mode for the navigation bar fixes #18511

caybro

LGTM in general, jsut some small things

ui/imports/shared/panels/PrivacyWallCarousel.qml

ui/StatusQ/src/StatusQ/Layout/StatusAppNavBar.qml

caybro · 2025-09-03T08:39:55Z

ui/StatusQ/src/assets/png/market/swap.png

Those PNG screenshots are unusually big (as in filesize) for their small size... have you tried running optipng on them?

caybro · 2025-09-03T08:40:33Z

ui/app/mainui/AppMain.qml

@@ -856,6 +856,9 @@ Item {
            }
            return username
        }
+
+        readonly property bool thirdPartyServicesDisbaled: featureFlagsStore.privacyModeFeatureEnabled &&


Suggested change

readonly property bool thirdPartyServicesDisbaled: featureFlagsStore.privacyModeFeatureEnabled &&

readonly property bool thirdPartyServicesDisabled: featureFlagsStore.privacyModeFeatureEnabled &&

Just a typo

caybro · 2025-09-03T08:42:33Z

ui/app/mainui/AppMain.qml

+                                                            dappMetrics.logNavigationEvent(DAppsMetrics.DAppsNavigationAction.DAppConnectInitiated)
+                                                            dAppsServiceLoader.dappConnectRequested()
+                                                        }
+                                onDappDisconnectRequested: (dappUrl) => {


See how the indentation is messed up inside the lambda... it's a QtCreator bug indeed but that's why I actually prefer the function(dappUrl) {} syntax here

noeliaSD

Great job @Khushboo-dev-cpp !

Tested on desktop and mobile. I've posted some comments in code and here are some other issues and suggestions I want to share:

Issues:

In wallet section, Organize collectibles your way - 3rd carousel image - the title is missing:

Wrong word here when in market section:

We should remove this selection Open in Status for mobile platforms since browser is not available there yet and if selected, it drives the app to a white screen non return page:

Screen.Recording.2025-09-05.at.12.47.12.mov

Design suggestions / concerns:

I think we should change the selected section icon color in light mode when in privacy mode since it's vaguely visible (also the hover color):

I think it would be nicer if the screenshots on dark mode are also shown on dark mode.
Wdyt if we add some smooth transition in between each screenshot. I feel they appear abruptly. OR, maybe extending a bit the time for each image?

cc: @xAlisher for the design questions

noeliaSD · 2025-09-05T10:12:16Z

storybook/pages/MarketPrivacyWallPage.qml

+
+    MarketPrivacyWall {
+        onOpenThirdpartyServicesInfoPopupRequested: console.warn("Enable third party services requested")
+        onOpenDiscussPageRequested: console.warn("Open discuss page requested")


Suggestion: You could create a Logs object and use the logs.logEvent so that we can see it inside a LogsAndControlsPanel component directly on the storybook environment

noeliaSD · 2025-09-05T10:12:57Z

storybook/pages/PrivacyWallCarouselPage.qml

+            }
+        }
+
+        onEnableThirdpartyServicesRequested: console.warn("Enable third party services requested")


Same comment than before!

noeliaSD · 2025-09-05T10:17:07Z

storybook/pages/WalletPrivacyWallPage.qml

+    id: root
+
+    WalletPrivacyWall {
+        onOpenThirdpartyServicesInfoPopupRequested: console.warn("Enable third party services requested")


Same comment than before! ;)

noeliaSD · 2025-09-05T10:19:58Z

ui/StatusQ/src/StatusQ/Layout/StatusAppNavBar.qml

@@ -27,7 +29,8 @@ Rectangle {

    implicitWidth: 78

-    color: Theme.palette.statusAppNavBar.backgroundColor
+    color: root.thirdpartyServicesDisabled ?
+               Theme.palette.customisationColors.purple : Theme.palette.statusAppNavBar.backgroundColor


Wondering if it would make sense to create a specific property in Theme.palette called something like privacyModeColor and do the asignement of the specific color inside the palette component?

noeliaSD · 2025-09-05T10:21:40Z

ui/app/AppLayouts/Wallet/WalletPrivacyWall.qml

+                image: "wallet/placeholders/swapView"
+            }
+            ListElement {
+                header: qsTr("Organize collectibles your way")


I guess this is the issue I posted on the global comment:

Suggested change

header: qsTr("Organize collectibles your way")

primary: qsTr("Organize collectibles your way")

noeliaSD · 2025-09-05T10:25:18Z

ui/app/mainui/AppMain.qml

@@ -856,6 +856,9 @@ Item {
            }
            return username
        }
+
+        readonly property bool thirdPartyServicesDisbaled: featureFlagsStore.privacyModeFeatureEnabled &&


Would it make sense to create a property inside the main root store (ui/app/AppLayouts/stores/RootStore.qml) instead since it seems a really global setting for the app? I see it at the same / similar level than isProduction or isOnline properties.

noeliaSD · 2025-09-05T10:28:43Z

ui/imports/shared/controls/LoadingPageIndicator.qml

Having it on shared folder makes me feel it's a statusq one ¿maybe?

Also a potential component to test on storybook?

noeliaSD · 2025-09-05T10:32:04Z

ui/imports/shared/panels/PrivacyWallCarousel.qml

+            font.pixelSize: Theme.additionalTextSize
+            wrapMode: Text.WordWrap
+
+            text: qsTr("Enable third-party services for wallet features to work.")


This should be customizable as well, so, or you add a new param in the model, or a property to set it up from outside.

Here it's the other issue described on the global comments, in case of market tab, the string changes slightly.

feat(@desktop/privacy): Added privacy wall screens for when third party

b268ecb

services are disabled fixes #18512, #18513

Khushboo-dev-cpp requested review from micieslak, a team, caybro, alexjba and noeliaSD as code owners August 29, 2025 13:10

Khushboo-dev-cpp requested review from vkjr and removed request for a team August 29, 2025 13:10

feat(@desktop/privacy): Create the new look and feel for the Privacy …

43ea202

…Mode for the navigation bar fixes #18511

caybro reviewed Sep 3, 2025

View reviewed changes

noeliaSD reviewed Sep 5, 2025

View reviewed changes

noeliaSD mentioned this pull request Sep 5, 2025

feat(@desktop/wallet): Adding UI flows for Enabling/Disabling Third #18684

Open

1 task

	readonly property bool thirdPartyServicesDisbaled: featureFlagsStore.privacyModeFeatureEnabled &&
	readonly property bool thirdPartyServicesDisabled: featureFlagsStore.privacyModeFeatureEnabled &&

	header: qsTr("Organize collectibles your way")
	primary: qsTr("Organize collectibles your way")

feat(@desktop/privacy): Added privacy wall screens for when third party #18750

Are you sure you want to change the base?

feat(@desktop/privacy): Added privacy wall screens for when third party #18750

Uh oh!

Conversation

Khushboo-dev-cpp commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does the PR do

Affected areas

Architecture compliance

Screencapture of the functionality

Impact on end user

How to test

Risk

Uh oh!

status-im-auto commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jenkins Builds

Uh oh!

caybro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

noeliaSD left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Khushboo-dev-cpp commented Aug 29, 2025 •

edited

Loading

status-im-auto commented Aug 29, 2025 •

edited

Loading