Skip to content

Conversation

AbhijitRaut04
Copy link
Contributor

@AbhijitRaut04 AbhijitRaut04 commented Oct 21, 2024

Resolves #225.

Description

What is the purpose of this pull request?

This pull request:

  • Calculates the secant for an input in radians
  • Also has the benchmarks, tests and examples

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
Screenshot 2024-10-21 192121
Screenshot 2024-10-21 192140
Screenshot 2024-10-21 204945

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Oct 21, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@AbhijitRaut04 AbhijitRaut04 changed the title feat: add math/base/special/sec feat: add support for secant functionality math/base/special/sec Oct 22, 2024
@kgryte kgryte added Needs Review A pull request which needs code review. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. labels Oct 26, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Oct 26, 2024
@AbhijitRaut04 AbhijitRaut04 requested a review from kgryte October 27, 2024 04:39
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is in good shape, I think. Left some minor comments but it should be ready for merging otherwise.

@AbhijitRaut04
Copy link
Contributor Author

Hi @Planeshifter and @kgryte,

I've made the requested changes and pushed them. Please let me know if anything else is needed. Thank you so much for your guidance throughout the process! 😊

This was my first contribution to an open-source project, and I’m thrilled to see this PR getting merged. Once again, thank you for your support!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Oct 29, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Oct 29, 2024

PR Commit Message

feat: add support for secant functionality `math/base/special/sec`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3027
Closes: https://github.com/stdlib-js/stdlib/issues/225

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>

Please review the above commit message and make any necessary adjustments.

Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit ed4c8d6 into stdlib-js:develop Oct 29, 2024
10 checks passed
@AbhijitRaut04
Copy link
Contributor Author

@Planeshifter Should I need to push the above changes ?

@Planeshifter
Copy link
Member

@AbhijitRaut04 All good, I was free to apply them and merged your PR! 🎉

Thanks again for your efforts.

Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Nov 9, 2024
PR-URL: stdlib-js#3027
Closes: stdlib-js#225

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
PR-URL: stdlib-js#3027
Closes: stdlib-js#225

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add support for computing the secant (sec)

4 participants