-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add support for secant functionality math/base/special/sec
#3027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
math/base/special/sec
math/base/special/sec
lib/node_modules/@stdlib/math/base/special/cos/test/fixtures/julia/huge_negative.json
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is in good shape, I think. Left some minor comments but it should be ready for merging otherwise.
Hi @Planeshifter and @kgryte, I've made the requested changes and pushed them. Please let me know if anything else is needed. Thank you so much for your guidance throughout the process! 😊 This was my first contribution to an open-source project, and I’m thrilled to see this PR getting merged. Once again, thank you for your support! |
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
lib/node_modules/@stdlib/math/base/special/sec/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Should I need to push the above changes ? |
@AbhijitRaut04 All good, I was free to apply them and merged your PR! 🎉 Thanks again for your efforts. |
PR-URL: stdlib-js#3027 Closes: stdlib-js#225 Co-authored-by: Athan Reines <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#3027 Closes: stdlib-js#225 Co-authored-by: Athan Reines <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Resolves #225.
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers