Skip to content

fix: Bug with skin tone emojis when using prevGraphemeClusterBreak package #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: Bug with skin tone emojis when using prevGraphemeClusterBreak package #2139

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce2e450
fix: Bug with skin tone emojis when using prevGraphemeClusterBreak pa…
olenkabilonizhka Apr 2, 2024
291f312
improvements after comments
olenkabilonizhka Apr 9, 2024
793c7bb
improvements after comments
olenkabilonizhka May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ function prevGraphemeClusterBreak( str, fromIndex ) {
var cp;
var i;

var regexEmoji = new RegExp("\\p{Extended_Pictographic}", "ug");
var regexEmojiMatching = str.match(regexEmoji)
if (regexEmoji.test(str) && regexEmojiMatching && regexEmojiMatching.length === 1) {
str = regexEmojiMatching[0];
}

if ( !isString( str ) ) {
throw new TypeError( format( 'invalid argument. First argument must be a string. Value: `%s`.', str ) );
}
Expand Down
9 changes: 9 additions & 0 deletions lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,3 +245,12 @@ tape( 'the function returns -1 if provided an empty string', function test( t )

t.end();
});

tape( 'the function returns -1 if provided a skin tone emoji', function test( t ) {
var out;

out = prevGraphemeClusterBreak( '👉🏿' );
t.strictEqual( out, -1, 'returns expected value' );

t.end();
});