-
-
Notifications
You must be signed in to change notification settings - Fork 907
fix: Bug with skin tone emojis when using prevGraphemeClusterBreak package #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(1) It looks like you are using language features which are beyond ES5. (2) You are performing repeated and unnecessary application of the regular expression. (3) Your PR is not accompanied by any additional tests.
As such, this PR cannot move forward until the above is addressed.
lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/prev-grapheme-cluster-break/lib/main.js
Outdated
Show resolved
Hide resolved
This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one. We appreciate your interest in contributing to stdlib! |
Resolves #1092
Description
There's an issue with prevGraphemeClusterBreak package, if I compare the results with nextGraphemeClusterBreak for a single skin tone emoji it doesn't return the same values,
Related Issues
This pull request:
prevGraphemeClusterBreak
package #1092Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers