Skip to content

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Aug 3, 2024

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_zeta( const double s );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Aug 3, 2024
@Planeshifter Planeshifter self-requested a review August 3, 2024 14:04
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Aug 3, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Aug 3, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter This PR needs changes before it can be merged.

@kgryte kgryte removed the Ready To Merge A pull request which is ready to be merged. label Aug 3, 2024
@kgryte kgryte added the Needs Review A pull request which needs code review. label Aug 12, 2024
@kgryte kgryte requested a review from Planeshifter August 12, 2024 00:42
@kgryte kgryte added the C Issue involves or relates to C. label Oct 4, 2024
@kgryte kgryte added the Needs Discussion Needs further discussion. label Nov 18, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 25, 2024

Coverage Report

Package Statements Branches Functions Lines
math/base/special/riemann-zeta $\color{red}888/914$
$\color{green}+97.16\%$
$\color{red}68/82$
$\color{green}+82.93\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{red}888/914$
$\color{green}+97.16\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 26, 2024

/stdlib merge

@kgryte kgryte removed the Needs Discussion Needs further discussion. label Nov 26, 2024
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 26, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 26, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 26, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the issue with the header file name. Left a round of comments. Once resolved, I believe this should resolve CI failures and we should be able to merge.

@kgryte
Copy link
Member

kgryte commented Nov 26, 2024

It's not clear to me why cppcheck is failing in CI. I wasn't able to spot anything off. I'll go ahead and merge, and we can address any issues in follow-up PRs.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 26, 2024
@kgryte kgryte merged commit e01c8e2 into stdlib-js:develop Nov 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants