Skip to content

Conversation

aayush0325
Copy link
Member

Resolves #1536 .

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • Open to reviews and willing to work futher on this if something else was expected from the Pull Request!

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 28, 2024
@aayush0325
Copy link
Member Author

@Planeshifter Ready for review!!

@Planeshifter Planeshifter self-requested a review September 29, 2024 00:29
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Sep 29, 2024
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Sep 29, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

refactor: updated `blas/ext/base/ssort2sh` to follow current project conventions

PR-URL: https://github.com/stdlib-js/stdlib/pull/2957
Closes: https://github.com/stdlib-js/stdlib/issues/1536

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: aayush0325 <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Copy link
Member

@aayush0325 Thanks, looks great!

Only updated indentation, where for *.c files, we want to consistently use TAB-indentation, whereas we use two spaces for JSON files, and line wrapping in the repl.txt.

Will merge shortly after CI has cleared.

@Planeshifter Planeshifter merged commit b57ae2e into stdlib-js:develop Sep 29, 2024
17 checks passed
@aayush0325
Copy link
Member Author

I'll keep that in mind for further issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssort2sh to follow current project conventions

3 participants