fix: ensure correct seed validation #3007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used a direct property check (`config.seed`), which could inadvertently treat falsy values like `0` as missing, leading to incorrect random seed initialization. Changed the condition to explicitly check for the presence of the `seed` property using `Object.prototype.hasOwnProperty.call()`. This update ensures that seed initialization handles falsy but valid seed values correctly. Resolves #2952. This pull request addresses the bug where setting `seed=0` leads to non-deterministic behavior. No related issues. No questions for reviewers. No additional information relevant to this pull request. - [x] Read, understood, and followed the [contributing guidelines][contributing]. --- @stdlib-js/reviewers [contributing]: https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md
1 task
kgryte
added
Needs Review
kgryte
changed the title
aayush0325
pushed a commit
to aayush0325/stdlib
that referenced
this pull request
Nov 11, 2024
The previous implementation used a direct property check (`config.seed`), which could inadvertently treat falsy values, such as `0`, as missing, leading to incorrect seed validation. PR-URL: stdlib-js#3007 Closes: stdlib-js#2952 Reviewed-by: Athan Reines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2952.
This pull request addresses the bug where setting
seed=0leads to non-deterministic behavior.Description
Reimplemented commit (#3005).
This pull request:
Related Issues
No.
Questions
Please tell if there is any scope of correction.
Other
No.
Checklist
@stdlib-js/reviewers