feat: add `math/base/special/cfloorf` #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Planeshifter merged 16 commits into stdlib-js:develop from aayush0325:cfloorf

Nov 11, 2024

Member

aayush0325 commented Nov 3, 2024

Resolves #649.

Description

What is the purpose of this pull request?

This pull request:

Resolves part of [RFC]: Add C implementations to base special math functions (tracking issue) #649 by adding math/base/special/cfloorf

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Open to reviews!!

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

aayush0325 added 8 commits

November 3, 2024 09:51


          feat: basic setup

e3817a5


          feat: c files added

8c413d8


          feat: js files added

20c9317


          feat: tests added

6d50858


          feat: examples added

7803e7a


          feat: docs added

0c69421


          chore: changes in docs

f5ef8a0


          feat: benchmarks added

stdlib-bot added the Math label

Member Author

aayush0325 commented Nov 3, 2024

Good Afternoon, can i kindly get your inputs in this @gunjjoshi ?

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/README.md Outdated Show resolved Hide resolved


          chore: changes from code review

f73da4b

Member Author

aayush0325 commented Nov 3, 2024

have pushed the changes @gunjjoshi , thanks!

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/README.md Outdated Show resolved Hide resolved

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/benchmark/benchmark.native.js Outdated Show resolved Hide resolved

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/benchmark/c/Makefile Outdated Show resolved Hide resolved

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/benchmark/c/benchmark.c Outdated Show resolved Hide resolved

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/binding.gyp Outdated Show resolved Hide resolved

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/examples/c/Makefile Outdated Show resolved Hide resolved

gunjjoshi changed the title ~~feat: add C implementation for math/base/special/cfloorf~~ feat: add math/base/special/cfloorf

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/examples/c/example.c Outdated Show resolved Hide resolved

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/examples/index.js Show resolved Hide resolved

gunjjoshi reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/include.gypi Outdated Show resolved Hide resolved

aayush0325 added 2 commits

November 3, 2024 19:18


          chore: changes from code review

566a85d


          chore: stuff from code review

3170b82

Member Author

aayush0325 commented Nov 3, 2024

pushed the changes @gunjjoshi .

aayush0325 requested a review from gunjjoshi

November 8, 2024 07:42

Planeshifter reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/benchmark/c/benchmark.c Outdated Show resolved Hide resolved

Planeshifter reviewed

View reviewed changes

lib/node_modules/@stdlib/math/base/special/cfloorf/README.md Outdated Show resolved Hide resolved

Planeshifter reviewed

View reviewed changes

Member

Planeshifter left a comment

Should be close to land (left two comments), thanks for your work on this!

aayush0325 added 5 commits

November 10, 2024 08:52


          chore: changes from code review

caafd0f


          fix: benchmark compilation errors

08c5953


          fix: compilation isssues in benchmarks

1793c88


          fix: compilation error in benchmark

75d9d38


          fix: compilation errors

757ba1a

Member Author

aayush0325 commented Nov 10, 2024 •

edited

Loading

wasn't exactly sure on how to proceed with this but i tried making some changes to make the benchmark work with stdlib_base_cfloorf, kindly let me know if i should take another approach @Planeshifter

aayush0325 requested a review from Planeshifter

November 11, 2024 07:34

Planeshifter approved these changes

View reviewed changes

Member

Planeshifter left a comment

Did another review pass; looks good to me. Thank you, @aayush0325!

Planeshifter added the Ready To Merge label

Contributor

stdlib-bot commented Nov 11, 2024

PR Commit Message

feat: add `math/base/special/cfloorf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3058
Closes: https://github.com/stdlib-js/stdlib/issues/649

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

Planeshifter merged commit 6556a46 into stdlib-js:develop

17 checks passed

aayush0325 deleted the cfloorf branch

November 11, 2024 14:17

Planeshifter mentioned this pull request

feat: add math/base/special/cfloorf #3053

Closed

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Ready To Merge