Skip to content

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Nov 6, 2024

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • updates Js implementation for ccopy.
  • adds C ndarray implementation for ccopy.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 6, 2024
@stdlib-js stdlib-js deleted a comment from stdlib-bot Nov 15, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/base/ccopy $\color{green}497/497$
$\color{green}+100.00\%$
$\color{green}31/31$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}497/497$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

CI failure is due to build error and not related to this PR. As such, will go ahead and merge.

@kgryte kgryte merged commit d7925a2 into stdlib-js:develop Nov 18, 2024
10 of 11 checks passed
@Planeshifter
Copy link
Member

@kgryte Failing CI was due to the following CI lint error:

Linting file: lib/node_modules/@stdlib/blas/base/ccopy/src/ccopy_ndarray.c
(information) Couldn't find path given by -I 'make[2]: Entering directory '/home/runner/work/stdlib/stdlib'/'
(information) Couldn't find path given by -I 'make[2]: Leaving directory '/home/runner/work/stdlib/stdlib'/'
lib/node_modules/@stdlib/blas/base/ccopy/src/ccopy_ndarray.c:34:9: style: Variable 'x' can be declared as pointer to const [constVariablePointer]
 float *x = (float *)X;
        ^
nofile:0:0: information: Active checkers: 114/835 (use --checkers-report=<filename> to see details) [checkersReport]

Unrelated to this PR?

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

@Planeshifter Ah, sorry, missed that in the -I noise. Hmm...this is likely applicable to other packages. Will investigate.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

@Planeshifter Fixed in a follow-up commit. Thanks for flagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants