Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves #3074

Description

This pull request:

  • Adds test cases to achieve 100% test coverage for the file:- blas/ext/base/dnansumkbn2

Related Issues

This pull request:

Questions

No.

Other

No.

Checklist


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 9, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR!

Please have a look at the failing CI checks.
Notice also that the .ndarray method has a different function signature than the main dnansumkbn2 one, expecting four arguments.

@Neerajpathak07
Copy link
Member Author

@Planeshifter sure I'll look into the falling checks and implement the necessary changes.

@Neerajpathak07 Neerajpathak07 changed the title test: Adding tests to achieve 100% test coverage for blas/ext/base/dnansumkbn2 test: achieve 100% test coverage for blas/ext/base/dnansumkbn2 Nov 10, 2024
@Neerajpathak07
Copy link
Member Author

@Planeshifter I'm finding it difficult to set up an environment and run those test cases could you help me a bit?

@headlessNode
Copy link
Member

@Neerajpathak07 Follow this guide https://github.com/stdlib-js/stdlib/blob/develop/docs/development.md

@Neerajpathak07 Neerajpathak07 deleted the Adding-test-cases branch November 12, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Incomplete code coverage for blas/ext/base/dnansumkbn2

4 participants