Skip to content

Conversation

gururaj1512
Copy link
Member

Resolves #3075.

Related Issues

Does this pull request have any related issues?

Adds a test case to achieve 100% test coverage for blas/ext/base/dnansumkbn

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 10, 2024
@Planeshifter Planeshifter changed the title test: acheive 100% test coverage for blas/ext/base/dnansumors test: achieve 100% test coverage for blas/ext/base/dnansumors Nov 11, 2024
Signed-off-by: Philipp Burckhardt <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gururaj1512!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 11, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

test: achieve 100% test coverage for `blas/ext/base/dnansumors`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3087
Closes: https://github.com/stdlib-js/stdlib/issues/3075

Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 02735b4 into stdlib-js:develop Nov 11, 2024
15 checks passed
@headlessNode
Copy link
Member

headlessNode commented Nov 11, 2024

@Planeshifter I think we should add the test case to both the test.dnansumors.js and test.ndarray.js and their native counterparts, as part of this PR/issue, for consistency across the packages.

@gururaj1512 gururaj1512 deleted the test-coverage-dnansumors branch December 7, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Incomplete code coverage for blas/ext/base/dnansumors

4 participants