Skip to content

feat: add math/base/special/lcmf #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 75 commits into from
Closed

feat: add math/base/special/lcmf #3096

wants to merge 75 commits into from

Conversation

Harsh-Mathur-1503
Copy link

@Harsh-Mathur-1503 Harsh-Mathur-1503 commented Nov 11, 2024 •
edited by gunjjoshi
Loading

Resolves a part of #649.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Open to reviews.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 11, 2024
@Harsh-Mathur-1503 Harsh-Mathur-1503 marked this pull request as ready for review November 11, 2024 11:23
@Harsh-Mathur-1503
Copy link
Author

@gunjjoshi I've worked on this package lcmf
Kindly review it

@Planeshifter Planeshifter self-requested a review November 11, 2024 14:05
@Planeshifter Planeshifter changed the title feat: add math/base/special/lcmf feat: add math/base/special/lcmf Nov 11, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Nov 11, 2024
gunjjoshi
gunjjoshi reviewed Nov 11, 2024
View reviewed changes
gunjjoshi
gunjjoshi reviewed Nov 11, 2024
View reviewed changes
gunjjoshi
gunjjoshi reviewed Nov 11, 2024
View reviewed changes
@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 11, 2024
@Harsh-Mathur-1503
Copy link
Author

@gunjjoshi I've done changes as requested by you
Kindly review it again for the same

gunjjoshi
gunjjoshi reviewed Nov 12, 2024
View reviewed changes
gunjjoshi
gunjjoshi reviewed Nov 12, 2024
View reviewed changes
gunjjoshi
gunjjoshi reviewed Nov 12, 2024
View reviewed changes
gunjjoshi
gunjjoshi reviewed Nov 12, 2024
View reviewed changes
gunjjoshi
gunjjoshi reviewed Nov 12, 2024
View reviewed changes
gunjjoshi
gunjjoshi reviewed Nov 12, 2024
View reviewed changes
gunjjoshi
gunjjoshi reviewed Nov 12, 2024
View reviewed changes
Harsh-Mathur-1503 and others added 14 commits November 16, 2024 18:12
@Harsh-Mathur-1503
Update example.c
d212d48 
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503
Update index.js
d28ccce 
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503
Merge branch 'stdlib-js:develop' into lcmf
78bc3c2
@Harsh-Mathur-1503 @gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/lcmf/lib/main.js
352a99c 
Co-authored-by: Gunj Joshi <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503 @gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/lcmf/lib/main.js
784cc9a 
Co-authored-by: Gunj Joshi <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503 @gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/lcmf/lib/main.js
5bacf39 
Co-authored-by: Gunj Joshi <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503
Update manifest.json
691cfb8 
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503 @gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/lcmf/src/main.c
8f44972 
Co-authored-by: Gunj Joshi <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503 @gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/lcmf/package.json
209d798 
Co-authored-by: Gunj Joshi <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503 @gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/lcmf/package.json
ca16cf7 
Co-authored-by: Gunj Joshi <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503 @gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/lcmf/package.json
03f16b9 
Co-authored-by: Gunj Joshi <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503 @gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/lcmf/package.json
4b74121 
Co-authored-by: Gunj Joshi <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503 @gunjjoshi
Update lib/node_modules/@stdlib/math/base/special/lcmf/src/main.c
ff495ab 
Co-authored-by: Gunj Joshi <[email protected]>
Signed-off-by: Harsh Mathur <[email protected]>
@Harsh-Mathur-1503
Merge branch 'stdlib-js:develop' into lcmf
9c39f1c
@stdlib-bot
Copy link
Contributor

Coverage Report

No coverage information available.

@Harsh-Mathur-1503
Copy link
Author

@gunjjoshi Resolved all issues mentioned by you.
Kindly review it ,if it's ready to be merged.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@Harsh-Mathur-1503
Copy link
Author

@kgryte is this ready to merge ?

gunjjoshi
gunjjoshi reviewed Nov 18, 2024
View reviewed changes
gunjjoshi
gunjjoshi reviewed Nov 18, 2024
View reviewed changes
lib/node_modules/@stdlib/math/base/special/lcmf/test/test.js
Comment on lines +41 to +48
v = lcmf( NaN, 10.0 );
t.strictEqual( isnanf( v ), true, 'returns NaN' );

v = lcmf( 10.0, NaN );
t.strictEqual( isnanf( v ), true, 'returns NaN' );

v = lcmf( NaN, NaN );
t.strictEqual( isnanf( v ), true, 'returns NaN' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use:

returns exprected value

here and in functions below.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

@Harsh-Mathur-1503 You'll need to address the various CI failures before this PR can be merged.

@gunjjoshi gunjjoshi mentioned this pull request Nov 18, 2024
Merged
1 task
@Harsh-Mathur-1503
Update test.js
d3343c0 
Signed-off-by: Harsh Mathur <[email protected]>
@gunjjoshi
Copy link
Member

@Harsh-Mathur-1503 We now have the implementation of math/base/special/lcmf, which was done via #3098. So, we can close this PR now.

@kgryte kgryte added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Jul 11, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gunjjoshi gunjjoshi gunjjoshi left review comments

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Assignees

No one assigned

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Harsh-Mathur-1503 @gunjjoshi @stdlib-bot @kgryte @Planeshifter