Skip to content

build: do not close tracking issues #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 28, 2024
Merged

build: do not close tracking issues #3106

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c697fc9
build: do not close tracking issues
gunjjoshi Nov 12, 2024
02c4234
style: fix indentation
gunjjoshi Nov 12, 2024
2089a5c
docs: add comments
gunjjoshi Nov 12, 2024
c670654
build: use only label, add a comment for reviewer
gunjjoshi Nov 13, 2024
8a368b7
build: refactor such that note is not added to commit message but Git…
Planeshifter Nov 28, 2024
8768d3d
chore: rename variable and tweak note
Planeshifter Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/scripts/generate_pr_commit_message
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,15 @@ main() {
keywords_pattern=$(IFS='|'; echo "${closing_keywords[*]}")

for issue in $issue_numbers; do
if echo "$pr_body" | grep -Eiq "(${keywords_pattern})([[:space:]]+|:)[[:space:]]*#${issue}\b"; then
# Fetch issue details:
issue_details=$(github_api "GET" "/repos/$REPO_OWNER/$REPO_NAME/issues/$issue")
issue_title=$(echo "$issue_details" | jq -r '.title')
issue_labels=$(echo "$issue_details" | jq -r '.labels[].name')

# Check if the issue is a tracking issue:
if echo "$issue_title" | grep -q "(tracking issue)" || echo "$issue_labels" | grep -q "Tracking Issue"; then
ref_issues+="Ref: https://github.com/$REPO_OWNER/$REPO_NAME/issues/$issue\n"
elif echo "$pr_body" | grep -Eiq "(${keywords_pattern})([[:space:]]+|:)[[:space:]]*#${issue}\b"; then
closes_issues+="Closes: https://github.com/$REPO_OWNER/$REPO_NAME/issues/$issue\n"
else
ref_issues+="Ref: https://github.com/$REPO_OWNER/$REPO_NAME/issues/$issue\n"
Expand Down