Skip to content

Conversation

gururaj1512
Copy link
Member

Resolves None.

Description

What is the purpose of this pull request?

  • This pull request adds package math/base/assert/is-oddf
bool stdlib_base_is_oddf( const float x );

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 17, 2024

Coverage Report

Package Statements Branches Functions Lines
math/base/assert/is-oddf $\color{green}163/163$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}163/163$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. labels Nov 18, 2024
@kgryte kgryte requested a review from gunjjoshi November 18, 2024 04:10
@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 18, 2024
@gunjjoshi gunjjoshi self-requested a review November 20, 2024 01:37
@gururaj1512
Copy link
Member Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 25, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 25, 2024
@kgryte kgryte mentioned this pull request Dec 3, 2024
1 task
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
@gunjjoshi
Copy link
Member

@kgryte We can proceed with this PR, rather than its duplicate at #3316, given that the changes in this PR look good, and as it was opened earlier.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this PR; thanks @gururaj1512!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 10, 2024
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Dec 10, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `math/base/assert/is-oddf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3125

Co-authored-by: Gunj Joshi <[email protected]>
Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit ecd017d into stdlib-js:develop Dec 10, 2024
20 checks passed
@gururaj1512 gururaj1512 deleted the is-oddf branch December 14, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants