Skip to content

Conversation

adityacodes30
Copy link
Contributor

@adityacodes30 adityacodes30 commented Nov 27, 2024

Resolves #3149

Description

What is the purpose of this pull request?

This pull request:

Related Issues

#3149

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 27, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}933/1192$
$\color{green}+78.27\%$
$\color{red}90/100$
$\color{green}+90.00\%$
$\color{red}16/27$
$\color{green}+59.26\%$
$\color{red}933/1192$
$\color{green}+78.27\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter self-requested a review November 30, 2024 23:31
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adityacodes30!

Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 30, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `lastIndexOf` method to `array/fixed-endian-factory`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3281
Closes: https://github.com/stdlib-js/stdlib/issues/3149

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit c8143c4 into stdlib-js:develop Nov 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add lastIndexOf method to array/fixed-endian-factory

3 participants