-
-
Notifications
You must be signed in to change notification settings - Fork 996
feat: add includes method to array/fixed-endian-factory
#3283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add includes method to array/fixed-endian-factory
#3283
Conversation
stdlib-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@ahmad-kashkoush the title should start with "feat:" |
includes() method to array/fixed-endian-factoryincludes() method to array/fixed-endian-factory
Done, may you review PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmad-kashkoush A few suggestions regarding the documentation, otherwise looks good. A more thorough review will be done by the maintainers. Also you should remove the parenthesis after includes in the title.
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
includes() method to array/fixed-endian-factoryincludes method to array/fixed-endian-factory
Co-authored-by: Muhammad Haris <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
Co-authored-by: Muhammad Haris <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
Co-authored-by: Muhammad Haris <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
|
Good evening, @kgryte may you this a review |
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ahmad-kashkoush!
|
@ahmad-kashkoush Would you mind resolving the merge conflicts? Once those are resolved, we can merge. Also, so that methods are listed in alphabetical order, |
changed its place before indexOf so file ordered alphatically
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
PR-URL: stdlib-js#3283 Closes: stdlib-js#3145 Co-authored-by: Athan Reines <[email protected]> Co-authored-by: Muhammad Haris <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Muhammad Haris <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Resolves #3145 .
Description
This pull request:
Related Issues
This pull request:
includesmethod toarray/fixed-endian-factory#3145Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers