feat: add includes method to array/fixed-endian-factory
#3283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Nov 27, 2024
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@ahmad-kashkoush the title should start with "feat:" |
ahmad-kashkoush
changed the title
includes() method to array/fixed-endian-factoryincludes() method to array/fixed-endian-factory
Done, may you review PR? |
headlessNode
requested changes
Nov 27, 2024
There was a problem hiding this comment.
@ahmad-kashkoush A few suggestions regarding the documentation, otherwise looks good. A more thorough review will be done by the maintainers. Also you should remove the parenthesis after includes in the title.
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
ahmad-kashkoush
changed the title
includes() method to array/fixed-endian-factoryincludes method to array/fixed-endian-factory
Co-authored-by: Muhammad Haris <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
Co-authored-by: Muhammad Haris <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
Co-authored-by: Muhammad Haris <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]>
|
Good evening, @kgryte may you this a review |
kgryte
reviewed
Dec 3, 2024
kgryte
reviewed
Dec 3, 2024
kgryte
reviewed
Dec 3, 2024
kgryte
reviewed
Dec 3, 2024
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Dec 3, 2024
kgryte
reviewed
Dec 3, 2024
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
approved these changes
Dec 3, 2024
|
@ahmad-kashkoush Would you mind resolving the merge conflicts? Once those are resolved, we can merge. Also, so that methods are listed in alphabetical order, |
kgryte
added
the
Needs Changes
changed its place before indexOf so file ordered alphatically
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
kgryte
removed
the
Needs Changes
jangnathan
pushed a commit
to jangnathan/stdlib
that referenced
this pull request
Dec 7, 2024
PR-URL: stdlib-js#3283 Closes: stdlib-js#3145 Co-authored-by: Athan Reines <[email protected]> Co-authored-by: Muhammad Haris <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Muhammad Haris <[email protected]> Signed-off-by: Ahmed_Kashkoush <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3145 .
Description
This pull request:
Related Issues
This pull request:
includesmethod toarray/fixed-endian-factory#3145Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers