Skip to content

Conversation

adityacodes30
Copy link
Contributor

@adityacodes30 adityacodes30 commented Nov 27, 2024

Resolves #3147

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 27, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}926/1183$
$\color{green}+78.28\%$
$\color{red}83/92$
$\color{green}+90.22\%$
$\color{red}16/27$
$\color{green}+59.26\%$
$\color{red}926/1183$
$\color{green}+78.28\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter self-requested a review November 30, 2024 23:36
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Made some small edits, but will merge shortly thereafter.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 30, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `join` method to `array/fixed-endian-factory`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3287
Closes: https://github.com/stdlib-js/stdlib/issues/3147

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 6ddda90 into stdlib-js:develop Nov 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add join method to array/fixed-endian-factory

3 participants