-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add with method to array/fixed-endian-factory
#3291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
good evening, kindly give this a review @kgryte! |
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, which looked good overall (fixed a few small things, see commit)!
Will merge after resolving merge conflicts.
Signed-off-by: Philipp Burckhardt <[email protected]>
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
ill keep in mind to cross check the function descriptions for my next contributions! sorry for that. |
|
@Planeshifter could you please approve the latest commit? it clears the mixed whitespaces linting error |
PR-URL: stdlib-js#3291 Closes: stdlib-js#3162 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]>
Resolves #3162
Description
This pull request:
withmethod toarray/fixed-endian-factoryREADME.mdwith suitable documentationRelated Issues
This pull request:
withmethod toarray/fixed-endian-factory#3162Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers