Skip to content

Conversation

aayush0325
Copy link
Member

Resolves #3162

Description

What is the purpose of this pull request?

This pull request:

  • adds with method to array/fixed-endian-factory
  • adds relevant tests and examples
  • updates README.md with suitable documentation

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 28, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}1131/1388$
$\color{green}+81.48\%$
$\color{red}142/152$
$\color{green}+93.42\%$
$\color{red}21/32$
$\color{green}+65.62\%$
$\color{red}1131/1388$
$\color{green}+81.48\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

good evening, kindly give this a review @kgryte!

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, which looked good overall (fixed a few small things, see commit)!

Will merge after resolving merge conflicts.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 1, 2024
Signed-off-by: Philipp Burckhardt <[email protected]>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 1, 2024

PR Commit Message

feat: add `with` method to `array/fixed-endian-factory`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3291
Closes: https://github.com/stdlib-js/stdlib/issues/3162

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@aayush0325
Copy link
Member Author

fixed a few small things, see commit

ill keep in mind to cross check the function descriptions for my next contributions! sorry for that.

@aayush0325
Copy link
Member Author

@Planeshifter could you please approve the latest commit? it clears the mixed whitespaces linting error

@Planeshifter Planeshifter merged commit a0ba090 into stdlib-js:develop Dec 2, 2024
11 checks passed
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 3, 2024
jangnathan pushed a commit to jangnathan/stdlib that referenced this pull request Dec 7, 2024
PR-URL: stdlib-js#3291
Closes: stdlib-js#3162

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
@aayush0325 aayush0325 deleted the with branch February 16, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add with method to array/fixed-endian-factory

4 participants