Skip to content

Conversation

aayush0325
Copy link
Member

Resolves #3151

Description

What is the purpose of this pull request?

This pull request:

  • adds reduce method to array/fixed-endian-factory
  • adds relevant tests and benchmarks
  • updates README.md with appropriate documentation

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 29, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}932/1189$
$\color{green}+78.39\%$
$\color{red}86/95$
$\color{green}+90.53\%$
$\color{red}16/27$
$\color{green}+59.26\%$
$\color{red}932/1189$
$\color{green}+78.39\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Member Author

greetings, kindly give this a review @kgryte!

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 30, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 30, 2024

PR Commit Message

feat: add `reduce` method to `array/fixed-endian-factory`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3296
Closes: https://github.com/stdlib-js/stdlib/issues/3151

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit b679536 into stdlib-js:develop Dec 1, 2024
18 checks passed
@aayush0325 aayush0325 deleted the reduce branch February 16, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add reduce method to array/fixed-endian-factory

3 participants