Skip to content

Conversation

ahmad-kashkoush
Copy link
Contributor

Resolves #3158.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 1, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}1179/1431$
$\color{green}+82.39\%$
$\color{red}156/169$
$\color{green}+92.31\%$
$\color{red}23/33$
$\color{green}+69.70\%$
$\color{red}1179/1431$
$\color{green}+82.39\%$

The above coverage report was generated for the changes in this PR.

@ahmad-kashkoush
Copy link
Contributor Author

Good evening, @kgryte may you give this a review

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. labels Dec 3, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @ahmad-kashkoush. This LGTM. If you wouldn't mind resolving the merge conflicts, that would be appreciated. Once resolved, should be ready for merge.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 3, 2024
@ahmad-kashkoush
Copy link
Contributor Author

Thanks for working on this, @ahmad-kashkoush. This LGTM. If you wouldn't mind resolving the merge conflicts, that would be appreciated. Once resolved, should be ready for merge.

@kgryte resolved conflicts, may you check it again?

@Planeshifter
Copy link
Member

@kgryte @ahmad-kashkoush Looks like the benchmarks here are very slow; this might warrant a look. At the minimum, should adjust the benchmark files so we don't have CI running for ~20min to run the benchmarks for this method.

@ahmad-kashkoush ahmad-kashkoush changed the title feat: add toLocaleString method to array/fixed-endian-factory feat: add toLocaleString method to array/fixed-endian-factory Dec 4, 2024
@ahmad-kashkoush
Copy link
Contributor Author

@kgryte @ahmad-kashkoush Looks like the benchmarks here are very slow; this might warrant a look. At the minimum, should adjust the benchmark files so we don't have CI running for ~20min to run the benchmarks for this method.

Working on it 🫡

@ahmad-kashkoush
Copy link
Contributor Author

@Planeshifter Can I reduce the benchmark scope?
the method itself runs in O(N) so can't be updated more to my knowledge
or may you suggest a better change I can do

@ahmad-kashkoush
Copy link
Contributor Author

@Planeshifter May you reply to that comment #3311 (comment),
So that I can continue working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add toLocaleString method to array/fixed-endian-factory

4 participants