-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add toLocaleString
method to array/fixed-endian-factory
#3311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: add toLocaleString
method to array/fixed-endian-factory
#3311
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
Good evening, @kgryte may you give this a review |
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @ahmad-kashkoush. This LGTM. If you wouldn't mind resolving the merge conflicts, that would be appreciated. Once resolved, should be ready for merge.
…oush/stdlib into fixed-endian-to-local-string
@kgryte resolved conflicts, may you check it again? |
@kgryte @ahmad-kashkoush Looks like the benchmarks here are very slow; this might warrant a look. At the minimum, should adjust the benchmark files so we don't have CI running for ~20min to run the benchmarks for this method. |
toLocaleString
method to array/fixed-endian-factorytoLocaleString
method to array/fixed-endian-factory
Working on it 🫡 |
@Planeshifter Can I reduce the benchmark scope? |
@Planeshifter May you reply to that comment #3311 (comment), |
Resolves #3158.
Description
This pull request:
toLocaleString
method to @stdlib/array/fixed-endian-factory.Related Issues
This pull request:
toLocaleString
method toarray/fixed-endian-factory
#3158Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers