Skip to content

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Dec 3, 2024
@gunjjoshi gunjjoshi changed the title docs: update js examples docs: update js examples in math/base/special/lcmf Dec 3, 2024
@gunjjoshi gunjjoshi changed the title docs: update js examples in math/base/special/lcmf docs: update examples in math/base/special/lcmf Dec 3, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 3, 2024

Coverage Report

Package Statements Branches Functions Lines
math/base/special/lcmf $\color{green}166/166$
$\color{green}+100.00\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}166/166$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Copy link
Member

Planeshifter commented Dec 3, 2024

@gunjjoshi You mind simplifying the example code further, please

var a = randu( 100, 0, 50 );
var b = randu( 100, 0, 50 );
var i;

?

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gunjjoshi!

@gunjjoshi
Copy link
Member Author

@gunjjoshi You mind simplifying the example code further, please

var a = randu( 100, 0, 50 );
var b = randu( 100, 0, 50 );
var i;

?

Done, thanks for the suggestion!

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi and @Planeshifter!

@kgryte kgryte merged commit 299517a into stdlib-js:develop Dec 3, 2024
10 checks passed
jangnathan pushed a commit to jangnathan/stdlib that referenced this pull request Dec 7, 2024
PR-URL: stdlib-js#3319
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants