Skip to content

Conversation

gururaj1512
Copy link
Member

Resolves #3327.

Description

What is the purpose of this pull request?

This pull request:

  • This RFC proposes adding the package @stdlib/constants/float32/sqrt-two returning square root of single-precision floating-point number 2.

Related Issues

Does this pull request have any related issues?

This pull request:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 4, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 4, 2024

Coverage Report

Package Statements Branches Functions Lines
constants/float32/sqrt-two $\color{green}55/55$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}55/55$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 5, 2024
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Dec 7, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `constants/float32/sqrt-two`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3328
Closes: https://github.com/stdlib-js/stdlib/issues/3327

Co-authored-by: Gururaj Gurram <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit cf471dc into stdlib-js:develop Dec 7, 2024
18 checks passed
@gururaj1512 gururaj1512 deleted the float32-sqrt-two branch December 7, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add constants/float32/sqrt-two

4 participants