Skip to content

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add the missing type property to the rules' meta, to allow auto-fixing.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 5, 2024
@headlessNode headlessNode added the Tools Issue or pull request related to project tooling. label Dec 5, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks!

I believe this rule typo for our project is accurate. It's not just a style / convention rule, but we have tooling that relies on being able to differentiate relative requires inside a package from other ones.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 7, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 7, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

fix: add the missing `type` property to meta for `eslint/rule/require-leading-slash`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3330

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit a8a5679 into stdlib-js:develop Dec 7, 2024
31 checks passed
@headlessNode headlessNode deleted the require-slash-bug branch December 8, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants