Skip to content

Conversation

Snehil-Shah
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray API for blas/ext/base/snansumpw.
  • refactors package to follow updated project conventions.
  • Updates stride handling where stride is equal to zero.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 13, 2024
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ssumors $\color{green}361/361$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}361/361$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactoring looks fine to me, thanks @Snehil-Shah!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 13, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 13, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C `ndarray` API and refactor `blas/ext/base/ssumors`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3891

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Snehil Shah <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 1f596cb into stdlib-js:develop Dec 13, 2024
37 checks passed
@Snehil-Shah Snehil-Shah deleted the ssumors-refactor branch December 17, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants