Skip to content

Conversation

gururaj1512
Copy link
Member

Resolves #3866.

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/dists/pareto-type1/stdev along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 15, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 15, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/pareto-type1/stdev $\color{green}203/203$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}203/203$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this PR! Left a few comments that we should address.

…EADME.md

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to land now after CI passes. Thanks, @gururaj1512!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 17, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 17, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/dists/pareto-type1/stdev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3925
Closes: https://github.com/stdlib-js/stdlib/issues/3866

Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 5ebf34e into stdlib-js:develop Dec 17, 2024
20 checks passed
@gururaj1512 gururaj1512 deleted the pareto-type1-stdev branch December 17, 2024 19:36
sethdivyansh pushed a commit to sethdivyansh/stdlib that referenced this pull request Dec 18, 2024
PR-URL: stdlib-js#3925
Closes: stdlib-js#3866

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/pareto-type1/stdev

3 participants