Skip to content

Conversation

@Vinit-Pandit
Copy link
Contributor

Resolves #3799 .

Description

What is the purpose of this pull request?

This pull request:

  • add c implementation of stats/base/dists/rayleigh/entropy

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 16, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 16, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/rayleigh/entropy $\color{green}164/164$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}164/164$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Vinit-Pandit Vinit-Pandit changed the title feat: add c implementation of stats/base/dists/rayleigh/entropy feat: add c implementation of stats/base/dists/rayleigh/entropy Dec 16, 2024
Signed-off-by: Vinit Pandit <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MeastroZI! Appreciate your proactive updates with improvements to the PR. It's looking good overall; I noticed a few more small things but otherwise this should be ready to land.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 17, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 17, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add c implementation of `stats/base/dists/rayleigh/entropy`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3956
Closes: https://github.com/stdlib-js/stdlib/issues/3799

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Vinit Pandit <[email protected]>
Co-authored-by: Vinit Pandit <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter changed the title feat: add c implementation of stats/base/dists/rayleigh/entropy feat: add C implementation of stats/base/dists/rayleigh/entropy Dec 17, 2024
@Planeshifter Planeshifter merged commit 4c46667 into stdlib-js:develop Dec 17, 2024
21 checks passed
@Vinit-Pandit
Copy link
Contributor Author

Thank You @Planeshifter , I will be more carefull from next time for this kind of issues.

sethdivyansh pushed a commit to sethdivyansh/stdlib that referenced this pull request Dec 18, 2024
PR-URL: stdlib-js#3956
Closes: stdlib-js#3799

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>
@Vinit-Pandit Vinit-Pandit deleted the stats/base/dists/rayleigh/entropy branch December 20, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/rayleigh/entropy

3 participants