Skip to content

Conversation

@Vinit-Pandit
Copy link
Contributor

@Vinit-Pandit Vinit-Pandit commented Dec 16, 2024

Resolves #3801

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 16, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 16, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/rayleigh/logcdf $\color{green}302/302$
$\color{green}+100.00\%$
$\color{green}31/31$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}302/302$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Vinit-Pandit Vinit-Pandit changed the title feat: add c implementation of stats/base/dists/rayleigh/logcdf feat: add c implementation of stats/base/dists/rayleigh/logcdf Dec 16, 2024
Signed-off-by: Vinit Pandit <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MeastroZI!

@Planeshifter Planeshifter changed the title feat: add c implementation of stats/base/dists/rayleigh/logcdf feat: add C implementation of stats/base/dists/rayleigh/logcdf Dec 17, 2024
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 17, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 17, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation of `stats/base/dists/rayleigh/logcdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3957
Closes: https://github.com/stdlib-js/stdlib/issues/3801

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Vinit Pandit <[email protected]>
Co-authored-by: Vinit Pandit <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 3a05645 into stdlib-js:develop Dec 17, 2024
21 checks passed
sethdivyansh pushed a commit to sethdivyansh/stdlib that referenced this pull request Dec 18, 2024
PR-URL: stdlib-js#3957
Closes: stdlib-js#3801

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Vinit Pandit <[email protected]>
@Vinit-Pandit Vinit-Pandit deleted the stats/base/dists/rayleigh/logcdf branch December 20, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/rayleigh/logcdf

3 participants