Skip to content

Conversation

@aayush0325
Copy link
Member

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • Makes use of the recently merged STDLIB_CONSTANT_FLOAT32_MAX_SAFE_NTH_LUCAS macro instead of a new variable in js and C files

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 17, 2024
@aayush0325 aayush0325 changed the title refactor: use inbuilt macro instead of new variable for MAX_SAFE_LUCAS in math/base/special/negalucasf refactor: use inbuilt macro instead of new variable for MAX_SAFE_NTH_LUCAS in math/base/special/negalucasf Dec 17, 2024
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/negalucasf $\color{green}221/221$
$\color{green}+100.00\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}221/221$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 17, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 17, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

refactor: use inbuilt macro instead of new variable for `MAX_SAFE_NTH_LUCAS` in `math/base/special/negalucasf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3980

Co-authored-by: aayush0325 <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 66b4609 into stdlib-js:develop Dec 17, 2024
36 checks passed
sethdivyansh pushed a commit to sethdivyansh/stdlib that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants