-
-
Notifications
You must be signed in to change notification settings - Fork 913
feat: add C implementation for stats/base/dists/normal/stdev
#4003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
stats/base/dists/normal/stdev
lib/node_modules/@stdlib/stats/base/dists/normal/stdev/src/main.c
Outdated
Show resolved
Hide resolved
double mu; | ||
double sigma; | ||
double y; | ||
int i; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically order the variable declarations by length:
double mu; | |
double sigma; | |
double y; | |
int i; | |
double sigma; | |
double mu; | |
double y; | |
int i; |
lib/node_modules/@stdlib/stats/base/dists/normal/stdev/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good and should be close to landing, but there were a few issues that still need to be addressed.
lib/node_modules/@stdlib/stats/base/dists/normal/stdev/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/normal/stdev/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/normal/stdev/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits! Will land PR shortly.
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Resolves #3783
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers