Skip to content

Conversation

@sethdivyansh
Copy link
Contributor

Resolves #3817

Description

  • adds C implementation for @stdlib/stats/base/dists/triangular/median along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 17, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/triangular/median $\color{red}195/197$
$\color{green}+98.98\%$
$\color{red}12/13$
$\color{green}+92.31\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{red}195/197$
$\color{green}+98.98\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title feat: add c implementation for dist/triangular/median feat: add C implementation for dist/triangular/median Dec 18, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

Left a few comments that will need to be addressed before this PR can be merged; hopefully should be quick to rectify.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 18, 2024
…in triangular median examples and benchmarks
@sethdivyansh
Copy link
Contributor Author

Thanks for your work!

Left a few comments that will need to be addressed before this PR can be merged; hopefully should be quick to rectify.

Done with the changes. Please review.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 18, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the edits! Will merge shortly after CI is all green.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 20, 2024
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Dec 20, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `dist/triangular/median`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4004
Closes: https://github.com/stdlib-js/stdlib/issues/3817

Co-authored-by: Divyansh Seth <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 8bb1cf3 into stdlib-js:develop Dec 20, 2024
29 checks passed
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4004
Closes: stdlib-js#3817

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/triangular/median

3 participants