-
-
Notifications
You must be signed in to change notification settings - Fork 915
feat: add C implementation for dist/triangular/median
#4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for dist/triangular/median
#4004
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
dist/triangular/median
lib/node_modules/@stdlib/stats/base/dists/triangular/median/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/triangular/median/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/triangular/median/lib/native.js
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/triangular/median/examples/c/example.c
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/triangular/median/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
Left a few comments that will need to be addressed before this PR can be merged; hopefully should be quick to rectify.
…in triangular median examples and benchmarks
Done with the changes. Please review. |
lib/node_modules/@stdlib/stats/base/dists/triangular/median/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/triangular/median/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the edits! Will merge shortly after CI is all green.
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
PR-URL: stdlib-js#4004 Closes: stdlib-js#3817 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]>
Resolves #3817
Description
This pull request:
@stdlib/stats/base/dists/triangular/median#3817Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers