Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves #3425 .

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/beta/kurtosis

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 19, 2024
@Neerajpathak07
Copy link
Member Author

@Planeshifter while adding c files for the packages which require:- stdlib/math/base/napi/binary.h it throws an error like:-

make[1]: Entering directory '/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/stats/base/dists/beta/kurtosis/benchmark/c'
/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/stats/base/dists/beta/kurtosis/src/main.c:19:10: fatal error: stdlib/stats/base/dists/beta/kurtosis.h: No such file or directory
   19 | #include "stdlib/stats/base/dists/beta/kurtosis.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
benchmark.c:19:10: fatal error: stdlib/stats/base/dists/beta/kurtosis.h: No such file or directory
   19 | #include "stdlib/stats/base/dists/beta/kurtosis.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:1[24](https://github.com/stdlib-js/stdlib/actions/runs/12408604772/job/34640587557?pr=4045#step:8:25): benchmark.out] Error 1
make[1]: Leaving directory '/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/stats/base/dists/beta/kurtosis/benchmark/c'

Similar issues can be seen while implementing C files for other packages ex;-
#4039, #3924.
are there any fixes for these?

@sethdivyansh
Copy link
Contributor

@Neerajpathak07 you have used eps in benchmark.c and example.c, but not included @stdlib/constants/float64/eps in the manifest.json. Including it will remove this error.

@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Dec 19, 2024

@sethdivyansh Ik where the error was and I did implement them in a local branch to test if it was working and it didn't if you would refer to the following linked PR's in them I have added all the necessary files and there implementation including eps in manifest.json file.
which is why I wanted to know if the error was constrained to my local device or any thing else.

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 2, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/beta/kurtosis $\color{green}197/197$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}197/197$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 2, 2025 15:52
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 2, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 16, 2025 14:56
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 16, 2025 18:44
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 16, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 17, 2025 07:45
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 17, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 17, 2025 16:16
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 17, 2025
@Planeshifter Planeshifter self-requested a review February 6, 2025 23:47
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land it; thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 6, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 6, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/beta/kurtosis`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4045
Closes: https://github.com/stdlib-js/stdlib/issues/3425

Co-authored-by: Neeraj Pathak <[email protected]>
Co-authored-by: Neerajpathak07 <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 01d6b11 into stdlib-js:develop Feb 7, 2025
29 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
PR-URL: stdlib-js#4045
Closes: stdlib-js#3425

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4045
Closes: stdlib-js#3425

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/beta/kurtosis

4 participants