Skip to content

feat: add C implementation for stats/base/dists/negative-binomial/mean #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 10, 2025
Merged

feat: add C implementation for stats/base/dists/negative-binomial/mean #4103

merged 9 commits into from
May 10, 2025

Conversation

manvith2003
Copy link
Contributor

@manvith2003 manvith2003 commented Dec 20, 2024 •
edited
Loading

Resolves #3763

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/negative-binomial/mean along with relevant tests, benchmarks and examples

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@manvith2003
feat: add C implementation for stats/base/dists/negative-binomial/mean
067f881 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 20, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 20, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/negative-binomial/mean $\color{green}197/197$
$\color{green}+100.00\%$ 		$\color{green}12/12$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}197/197$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Dec 20, 2024 •
edited
Loading

@manvith2003 please add backticks at the beginning and ending before naming the package name.
EX:-
stats/base/dists/negative-binomial/mean
similarly apply them to all the other pr's

@manvith2003 manvith2003 changed the title feat: add C implementation for stats/base/dists/negative-binomial/mean feat: add C implementation for stats/base/dists/negative-binomial/mean Dec 21, 2024
@Planeshifter Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label May 5, 2025
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels May 5, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label May 5, 2025
@Planeshifter
chore: apply suggestions from code review
a93ddff 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
docs: remove comment
c6b9d2d 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
docs: fix function name
2097a5a 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter previously approved these changes May 10, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will land once CI checks have passed.

@Planeshifter
fix: update positioning of added space
65ec703 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter previously approved these changes May 10, 2025
View reviewed changes
@Planeshifter
style: fix trailing space
62fe488 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter previously approved these changes May 10, 2025
View reviewed changes
@Planeshifter
docs: remove trailing spaces
abf7819 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed bot: In Progress Pull request is currently awaiting automation. labels May 10, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/negative-binomial/mean`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4103
Closes: https://github.com/stdlib-js/stdlib/issues/3763

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 10, 2025
@Planeshifter Planeshifter merged commit b9f0378 into stdlib-js:develop May 10, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/negative-binomial/mean

4 participants

@manvith2003 @stdlib-bot @Neerajpathak07 @Planeshifter