Skip to content

feat: add C implementation for stats/base/dists/pareto-type1/pdf #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 23, 2025
Merged

feat: add C implementation for stats/base/dists/pareto-type1/pdf #4452

merged 15 commits into from
Jun 23, 2025

Conversation

ShabiShett07
Copy link
Contributor

Resolves #3863

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 2, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 2, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/pareto-type1/pdf $\color{red}336/339$
$\color{green}+99.11\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{red}3/4$
$\color{green}+75.00\%$ 		$\color{red}336/339$
$\color{green}+99.11\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07
Copy link
Contributor Author

/stdlib check-files

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 2, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 2, 2025
@ShabiShett07 ShabiShett07 changed the title feat: add @stdlib/stats/base/dists/pareto-type1/pdf feat: add stats/base/dists/pareto-type1/pdf Jan 6, 2025
@Planeshifter Planeshifter self-requested a review April 2, 2025 00:21
@ShabiShett07 ShabiShett07 changed the title feat: add stats/base/dists/pareto-type1/pdf feat: add C implementation for stats/base/dists/pareto-type1/pdf Apr 23, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 23, 2025
ShabiShett07 and others added 4 commits April 23, 2025 11:36
@ShabiShett07
chore: update implementation
8320037
@Planeshifter
fix: modernize PRNG usage and fix parameter constraints in pareto-typ…
260ca3e 
…e1/pdf

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@Planeshifter
fix: simplify example and benchmark in pareto-type1/pdf
bd72178 
- Remove constraint loops from example, use safe ranges
- Move random generation outside benchmark timing loop
- Use individual uniform calls with proper parameter constraints

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@Planeshifter
Merge branch 'develop' into feature/pareto-type1
fb86adf 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
bench: restore benchmark
8cbffc9 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
chore: minor clean-up
d8f9897 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
chore: minor clean-up
ac3ad2b 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter previously approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in. 👍

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 23, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 23, 2025 •
edited by Planeshifter
Loading

PR Commit Message

feat: add C implementation for `stats/base/dists/pareto-type1/pdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4452
Closes: https://github.com/stdlib-js/stdlib/issues/3863

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 23, 2025
@Planeshifter
fix: add missing dependency
ea0ade7 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter previously approved these changes Jun 23, 2025
View reviewed changes
@Planeshifter
fix: remove trailing comma
d6bbc15 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter previously approved these changes Jun 23, 2025
View reviewed changes
@Planeshifter
fix: add missing package.json fields
eca6e8e 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: remove extra trailing newline
f6b3116 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: turn spaces to tab
85ac676 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit 21768a1 into stdlib-js:develop Jun 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/pareto-type1/pdf

3 participants

@ShabiShett07 @stdlib-bot @Planeshifter