Skip to content

feat: add C implementation for stats/base/dists/chi/pdf #4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 19, 2025
Merged

feat: add C implementation for stats/base/dists/chi/pdf #4526

merged 9 commits into from
Jun 19, 2025

Conversation

AadishJ
Copy link
Contributor

@AadishJ AadishJ commented Jan 4, 2025

Resolves #3495.

Description

What is the purpose of this pull request?

This pull request:

  • Adds a C implementation of the chi pdf.
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the chi pdf in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 4, 2025
@AadishJ
Copy link
Contributor Author

AadishJ commented Jan 4, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 4, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 4, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 4, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/chi/pdf $\color{green}304/304$
$\color{green}+100.00\%$ 		$\color{green}27/27$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}304/304$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jun 19, 2025
@Planeshifter
fix: chi pdf c implementation and tests
e3d0470 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter
chore: minor clean-up
eaf32f8 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
Merge branch 'develop' into develop14
eb658d1 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
chore: remove duplicated logic
60a64f8 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to land!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 19, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 19, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 19, 2025 •
edited by Planeshifter
Loading

PR Commit Message

feat: add C implementation for `stats/base/dists/chi/pdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4526
Closes: https://github.com/stdlib-js/stdlib/issues/3495

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Aadish Jain <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit b02b1dc into stdlib-js:develop Jun 19, 2025
29 checks passed
kgryte
kgryte reviewed Jun 19, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/chi/pdf/test/test.native.js
} else {
delta = abs( y - expected[ i ] );
tol = 2.0 * EPS * abs( expected[ i ] );
if ( tol < 1e-14 ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter This should have been flagged. This is not how we do tolerances.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@kgryte kgryte kgryte left review comments

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/chi/pdf

4 participants

@AadishJ @stdlib-bot @Planeshifter @kgryte