feat(stats): add C implementation for `stats/base/dists/hypergeometric/stdev` #4559

anandkaranubc · 2025-01-05T10:41:55Z

Resolves

#3667

Description

Purpose of this pull request

This pull request:

Adds a C implementation of the hypergeometric standard deviation.
Includes benchmarks for the C implementation.
Provides examples demonstrating the usage of the hypergeometric standard deviation in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Resolves Issue #3667.

Questions

Any questions for reviewers of this pull request?

No.

Other Information

Any other relevant information?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request:

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

anandkaranubc · 2025-01-05T10:42:09Z

/stdlib update-copyright-years

anandkaranubc · 2025-01-05T10:43:59Z

/stdlib lint-autofix

stdlib-bot · 2025-01-05T10:44:42Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/hypergeometric/stdev	$\color{green}203/203$ $\color{green}+100.00\%$	$\color{green}13/13$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}203/203$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

anandkaranubc · 2025-01-11T08:17:55Z

/stdlib update-copyright-years

…eneration --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

Signed-off-by: Karan Anand <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

anandkaranubc · 2025-02-17T02:39:12Z

/stdlib merge

Signed-off-by: Karan Anand <[email protected]>

Planeshifter · 2025-03-01T02:45:30Z

lib/node_modules/@stdlib/stats/base/dists/hypergeometric/stdev/src/main.c

+	double variance;
+	double p;
+
+	if (  N < 0 || K < 0 || n < 0 || N == STDLIB_CONSTANT_FLOAT64_PINF || K == STDLIB_CONSTANT_FLOAT64_PINF || K > N || n > N ) {


Checks for infinity are not needed.

Sorry about that. Doing it rn!

Planeshifter

Looks good overall.

Let's remove the infinity checks and then this PR should be ready to land.

anandkaranubc · 2025-03-01T03:22:11Z

/stdlib merge

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

Planeshifter

Let's get it in! 🎉

stdlib-bot · 2025-03-01T13:27:25Z

PR Commit Message

feat(stats): add C implementation for `stats/base/dists/hypergeometric/stdev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4559
Ref: https://github.com/stdlib-js/stdlib/issues/3667

Co-authored-by: Karan Anand <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Karan Anand <[email protected]>

Please review the above commit message and make any necessary adjustments.

anandkaranubc added 5 commits January 5, 2025 02:36

feat: add the C src files

84141ae

feat: add the C benchmark and example files

a752faf

build: added the json and gyp dependency files

574808d

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 5, 2025

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 5, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 5, 2025

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 5, 2025

anandkaranubc marked this pull request as draft January 8, 2025 02:19

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 8, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2025

chore: update copyright years

1d5e74d

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2025

anandkaranubc marked this pull request as ready for review January 11, 2025 08:27

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 11, 2025

anandkaranubc marked this pull request as draft January 16, 2025 00:25

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025

anandkaranubc and others added 2 commits January 28, 2025 22:14

Merge branch 'stdlib-js:develop' into rfc/hypergeom-stdev

68b83d1

anandkaranubc marked this pull request as ready for review January 29, 2025 06:59

chore: fix variable order

83bde37

Signed-off-by: Karan Anand <[email protected]>

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Feb 17, 2025

Merge branch 'develop' into rfc/hypergeom-stdev

4a29284

Signed-off-by: Karan Anand <[email protected]>

Planeshifter reviewed Mar 1, 2025

View reviewed changes

Planeshifter requested changes Mar 1, 2025

View reviewed changes

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 1, 2025

Merge remote-tracking branch 'upstream/develop' into rfc/hypergeom-stdev

9edef1b

stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed bot: In Progress Pull request is currently awaiting automation. labels Mar 1, 2025

anandkaranubc added 2 commits February 28, 2025 19:28

anandkaranubc requested a review from Planeshifter March 1, 2025 03:39

stdlib-bot added the Needs Review A pull request which needs code review. label Mar 1, 2025

Planeshifter approved these changes Mar 1, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 1, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 1, 2025

Planeshifter merged commit d847b9d into stdlib-js:develop Mar 1, 2025
44 checks passed

anandkaranubc deleted the rfc/hypergeom-stdev branch May 10, 2025 14:35

Uh oh!

feat(stats): add C implementation for stats/base/dists/hypergeometric/stdev #4559

feat(stats): add C implementation for stats/base/dists/hypergeometric/stdev #4559

Uh oh!

Conversation

anandkaranubc commented Jan 5, 2025

Resolves

Description

Purpose of this pull request

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

Other Information

Any other relevant information?

Checklist

Uh oh!

anandkaranubc commented Jan 5, 2025

Uh oh!

anandkaranubc commented Jan 5, 2025

Uh oh!

stdlib-bot commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

anandkaranubc commented Jan 11, 2025

Uh oh!

anandkaranubc commented Feb 17, 2025

Uh oh!

Planeshifter Mar 1, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Mar 1, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented Mar 1, 2025

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Mar 1, 2025

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(stats): add C implementation for `stats/base/dists/hypergeometric/stdev` #4559

feat(stats): add C implementation for `stats/base/dists/hypergeometric/stdev` #4559

stdlib-bot commented Jan 5, 2025 •

edited

Loading