feat(stats): add C implementation for `stats/base/dists/hypergeometric/skewness` #4560

anandkaranubc · 2025-01-05T11:10:36Z

Resolves

#3666

Description

Purpose of this pull request

This pull request:

Adds a C implementation of the skewness of a hypergeometric distribution.
Includes benchmarks for the C implementation.
Provides examples demonstrating the usage of the hypergeometric skewness in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Resolves Issue #3666.

Questions

Any questions for reviewers of this pull request?

No.

Other Information

Any other relevant information?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request:

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-01-05T11:13:18Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/hypergeometric/skewness	$\color{green}203/203$ $\color{green}+100.00\%$	$\color{green}13/13$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}203/203$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

anandkaranubc · 2025-01-08T07:51:33Z

Made the changes, taking feedback from #4593

anandkaranubc · 2025-01-08T07:51:39Z

/stdlib lint-autofix

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

anandkaranubc · 2025-01-09T03:43:04Z

/stdlib update-copyright-years

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

…eneration --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

anandkaranubc · 2025-02-17T02:39:21Z

/stdlib merge

…ewness

Planeshifter · 2025-03-01T02:08:23Z

lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/README.md

+-   **n**: `[in] int32_t` number of draws.
+
+```c
+double stdlib_base_dists_hypergeometric_skewness ( const int32_t N, const int32_t K, const int32_t n );


Suggested change

double stdlib_base_dists_hypergeometric_skewness ( const int32_t N, const int32_t K, const int32_t n );

double stdlib_base_dists_hypergeometric_skewness( const int32_t N, const int32_t K, const int32_t n );

Planeshifter · 2025-03-01T02:12:31Z

lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/src/main.c

+#include "stdlib/stats/base/dists/hypergeometric/skewness.h"
+#include "stdlib/math/base/special/sqrt.h"
+#include "stdlib/constants/float64/pinf.h"
+


I believe we need #include <stdint.h> here.

Planeshifter · 2025-03-01T02:14:21Z

lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/src/main.c

+	double p;
+	double q;
+
+	if (  N < 0 || K < 0 || n < 0 || N == STDLIB_CONSTANT_FLOAT64_PINF || K == STDLIB_CONSTANT_FLOAT64_PINF || K > N || n > N ) {


Since N and K are int32, they can never be infinity.

Planeshifter

Thanks, Karan!

Left a few comments.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

Planeshifter

Thanks! Lgtm.

stdlib-bot · 2025-03-01T13:27:45Z

PR Commit Message

feat(stats): add C implementation for `stats/base/dists/hypergeometric/skewness`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4560
Ref: https://github.com/stdlib-js/stdlib/issues/3666

Co-authored-by: Karan Anand <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

anandkaranubc added 5 commits January 5, 2025 03:06

feat: add the C src files

e9091f3

feat: add the C benchmark and example files

4af8808

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 5, 2025

anandkaranubc marked this pull request as draft January 8, 2025 02:19

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 8, 2025

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 8, 2025

anandkaranubc marked this pull request as ready for review January 8, 2025 07:55

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 8, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 9, 2025

chore: update copyright years

0049f53

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 9, 2025

anandkaranubc added 3 commits January 10, 2025 22:24

anandkaranubc marked this pull request as draft January 16, 2025 00:25

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025

anandkaranubc and others added 2 commits January 28, 2025 22:59

Merge branch 'stdlib-js:develop' into rfc/hypergeom-skewness

d8d17b5

anandkaranubc marked this pull request as ready for review January 29, 2025 08:07

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 17, 2025

Merge remote-tracking branch 'upstream/develop' into rfc/hypergeom-sk…

59b3fe1

…ewness

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 17, 2025

Planeshifter reviewed Mar 1, 2025

View reviewed changes

Planeshifter requested changes Mar 1, 2025

View reviewed changes

Merge branch 'stdlib-js:develop' into rfc/hypergeom-skewness

538b70f

stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 1, 2025

anandkaranubc requested a review from Planeshifter March 1, 2025 03:52

stdlib-bot added the Needs Review A pull request which needs code review. label Mar 1, 2025

Planeshifter approved these changes Mar 1, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 1, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 1, 2025

Planeshifter merged commit 61bb593 into stdlib-js:develop Mar 1, 2025
44 checks passed

anandkaranubc deleted the rfc/hypergeom-skewness branch May 10, 2025 14:35

	double stdlib_base_dists_hypergeometric_skewness ( const int32_t N, const int32_t K, const int32_t n );
	double stdlib_base_dists_hypergeometric_skewness( const int32_t N, const int32_t K, const int32_t n );

Uh oh!

feat(stats): add C implementation for stats/base/dists/hypergeometric/skewness #4560

feat(stats): add C implementation for stats/base/dists/hypergeometric/skewness #4560

Uh oh!

Conversation

anandkaranubc commented Jan 5, 2025

Resolves

Description

Purpose of this pull request

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

Other Information

Any other relevant information?

Checklist

Uh oh!

stdlib-bot commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

anandkaranubc commented Jan 8, 2025

Uh oh!

anandkaranubc commented Jan 8, 2025

Uh oh!

anandkaranubc commented Jan 9, 2025

Uh oh!

anandkaranubc commented Feb 17, 2025

Uh oh!

Planeshifter Mar 1, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 1, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 1, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Mar 1, 2025

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(stats): add C implementation for `stats/base/dists/hypergeometric/skewness` #4560

feat(stats): add C implementation for `stats/base/dists/hypergeometric/skewness` #4560

stdlib-bot commented Jan 5, 2025 •

edited

Loading